Add license rule importance flags #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Ombredanne <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #1140 +/- ##
===========================================
+ Coverage 84.11% 84.31% +0.19%
===========================================
Files 113 113
Lines 12422 12592 +170
===========================================
+ Hits 10449 10617 +168
- Misses 1973 1975 +2
Continue to review full report at Codecov.
|
And do not use a default License text for these Signed-off-by: Philippe Ombredanne <[email protected]>
Also remove or update some rules as needed Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Also remove or update some rules as needed Signed-off-by: Philippe Ombredanne <[email protected]>
Also remove or update some rules as needed Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Add is_ prefix to negative and false_positive flags This is consistent with the naming of other flags. Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
979-license-rule-importance-flags
branch
from
f3c0f82 to
462eb84
Compare
|
This is also renaming rule flaqs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a new set of flags on license rule to state the importance of a rule for #979. A rule is more important if its detection is the clearer mark of a license.
The importance flags are:
is_license_text: this is a full license textis_license_notice: this is a license noticeis_license_reference: this is a only a reference to a license and therefore may not be as strongis_license_tag: this is a a structured, coded license reference such as a SPDX-License-Identifier and is typically a strong license reference albeit a short one.Licenses are also tagged using a first set of heuristics and then a review.
License importance is useful for improve summarization and license determination automation for #377
Signed-off-by: Philippe Ombredanne [email protected]