-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scancode-toolkit release is a scancode-toolkit-mini release #3421
Comments
I also did notice something fishy is going on when we encountered #3408 but did not figure this out. 😅 |
Set the package name in setup-mini.cfg as scancode-toolkit-mini to correctly generate the wheels. Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
I also was just thinking about creating a ticket that there is no scancode-mini release on pypi. But seems to be covered by this bug here |
@maxhbr yes! Should be fixed an released soon too |
Fix scancode-toolkit-mini and release prep v32.0.3 #3421
@maxhbr do test out https://pypi.org/project/scancode-toolkit-mini/32.0.3/ and let us know if this works properly, thanks! |
@AyanSinhaMahapatra can we add a check step to validate that we have all the release archives published OK? This could be a simple as checking https://pypi.org/pypi/scancode-toolkit-mini/json and https://pypi.org/pypi/scancode-toolkit/json and check we have the published version as the last "release" for each? |
@pombredanne this would be a step in the release script after the pypi wheels are published? |
Description
We don't have scancode-toolkit mini releases after v32.0.rc1: https://pypi.org/project/scancode-toolkit-mini/32.0.0rc1/#history
This is due to dd15f72#r116748649 in #3207 which went unnoticed.
As a result, we have only a scancode-toolkit pip release which is originally the scancode-toolkit-mini, and no actual scancode-toolkit release. Here in the release script both the wheels have same name, and so the later is only present in the release: https://github.com/nexB/scancode-toolkit/blob/develop/etc/release/scancode-create-pypi-wheel.sh
The text was updated successfully, but these errors were encountered: