-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Vulnerabilities tab in the Product details view #95 #173
Conversation
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
@DennisClark This is ready for review. |
@tdruez The new "Vulnerabilities" tab is very impressive, and performance is excellent; however, I noticed a discrepancy that is a bit confusing. In Staging Starship, I opened product Astrolabe 2.5.7 and the Vulnerabilities tab presents 25 rows, but when I go to the Inventory tab and use the Filter "Affected by vulnerabilities", I only see 11 rows. Wait, I think I just figured it out. One of the packages pkg:pypi/[email protected] has 13 vulnerabilities, and some others have more than one as well. The Inventory tab is a listing of packages (and components) and the Vulnerabilities tab is a listing of the vulnerabilities, and one can easily see that a number of packages are repeated in the right column. Great. So far so good then ! No problems found. |
@tdruez , the new Vulnerabilities tab works quite well to provide information, and in that respect it is working just fine. I think we still need the filter on the Inventory tab, because that is where the user can access the Product-Package relationship and update the review status and add notes, etc. I think this one is ready to deploy. |
No description provided.