Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear how to disable reportNotMentioned #67

Closed
moltar opened this issue Jan 18, 2020 · 1 comment · Fixed by #69
Closed

Unclear how to disable reportNotMentioned #67

moltar opened this issue Jan 18, 2020 · 1 comment · Fixed by #69
Labels
bug Something isn't working

Comments

@moltar
Copy link

moltar commented Jan 18, 2020

It seems to be true by default. But there is no config option to disable that. And the command line flag appears to be a boolean flag, which has no negative option (e.g. --no-reportNotMentioned).

My use case is to generate a glossary of terms, but there isn't any body of text attached to the terms. It's a set of industry terms that organization member should be familiar with, but not necessarily included into any text.

Thanks.

@about-code about-code added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jan 19, 2020
about-code added a commit that referenced this issue Jan 19, 2020
…pass `--reportNotMentioned` explicitely via command line or config file to keep on being informed about unused terms." (#67)
@about-code
Copy link
Owner

@moltar Thank you for your interest in glossarify-md and reporting this. The implementation has been ignoring the option completely and just used the default of true from the libraries internal config schema.

This will be fixed with release of v3.3.0. Reporting on terms not being mentioned anywhere is now off by default and must be enabled explicitely, either with reportNotMentioned provided on command line or in config file. While this may look like a breaking change I don't think it is, because reporting is just informal behavior. Everything else continues to work as expected and the fix eventually makes things work as promised.

about-code added a commit that referenced this issue Jan 19, 2020
fix: Option `--reportNotMentioned` is ignored. With this fix please pass `--reportNotMentioned` explicitely via command line or config file to keep on being informed about unused terms." (#67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants