fix: Race condition which causes upgrade assistant to write new confi…

…g to backup file.
about-code · Dec 22, 2020 · f419aa7 · f419aa7
1 parent d4c8646
commit f419aa7
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/cli/upgrade.js b/lib/cli/upgrade.js
@@ -1,4 +1,4 @@
-const {copy, writeFile} = require("fs-extra");
+const {copySync, writeFile} = require("fs-extra");
 const inquirer = require("inquirer");
 
 const upgrades = [v4To5];
@@ -90,10 +90,12 @@ function upgrade(confData, confFile, defaultConf) {
             return new Promise((resolve, reject) => {
                 if (answers.keepBackup) {
                     const backupFile = confFile + ".old";
-                    copy(confFile, backupFile, (err) => {
-                        if (err) { reject(err); }
+                    try {
+                        copySync(confFile, backupFile);
                         console.info(`Backup of previous configuration in '${backupFile}'`);
-                    });
+                    } catch (err) {
+                        reject(err);
+                    };
                 }
                 const newConf = performUpgrades(confData, effectiveVersion);
                 if (hasUpgradePath(newConf, effectiveVersion)) {