Add support for opening counsel-git-grep in other window #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil-conto
requested changes
Apr 27, 2024
basil-conto
requested changes
Apr 30, 2024
basil-conto
added a commit
to flooose/swiper
that referenced
this pull request
May 12, 2024
* counsel.el (counsel-git-grep-function): Simplify. (counsel--git-grep-file-and-line-number): Rename... (counsel--git-grep-file-and-line): ...to this, splitting long lines. (counsel--git-grep-go-to-location): Rename... (counsel--git-grep-visit): ...to this, incorporating more DRY. (counsel-git-grep-action, counsel-git-grep-action-other-window): Adapt accordingly (abo-abo#3044).
basil-conto
approved these changes
May 12, 2024
|
Heyhey, my copyright assignment just got in. What do next steps look like? Do you need a copy of the document? |
Excellent! 🎉
I'll merge this as soon as I get a chance over the coming days :).
No need, I was already CCed in the email from the copyright clerk. |
|
@basil-conto Is this ready to be merged :) |
basil-conto
added a commit
to flooose/swiper
that referenced
this pull request
Jan 9, 2025
* counsel.el (counsel-git-grep-function): Simplify. (counsel--git-grep-file-and-line-number): Rename... (counsel--git-grep-file-and-line): ...to this, splitting long lines. (counsel--git-grep-go-to-location): Rename... (counsel--git-grep-visit): ...to this, incorporating more DRY. (counsel-git-grep-action, counsel-git-grep-action-other-window): Adapt accordingly (abo-abo#3044).
basil-conto
force-pushed
the
flooose/counsel-git-grep-other-window
branch
from
058cb3a to
fbc4b89
Compare
Of course, thank you for the reminder! And sorry about the long delay :(. |
* counsel.el (counsel-git-grep-action): Refactor in terms of counsel--git-grep-file-and-line-number and counsel--git-grep-go-to-location. (counsel-git-grep-action-other-window) (counsel--git-grep-file-and-line-number) (counsel--git-grep-go-to-location): New functions. (counsel-git-grep): Set "j" action to counsel-git-grep-action-other-window (abo-abo#3044). Closes abo-abo#3043.
* counsel.el (counsel-git-grep-function): Simplify. (counsel--git-grep-file-and-line-number): Rename... (counsel--git-grep-file-and-line): ...to this, splitting long lines. (counsel--git-grep-go-to-location): Rename... (counsel--git-grep-visit): ...to this, incorporating more DRY. (counsel-git-grep-action, counsel-git-grep-action-other-window): Adapt accordingly (abo-abo#3044).
basil-conto
force-pushed
the
flooose/counsel-git-grep-other-window
branch
from
fbc4b89 to
2393ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality described in related issue