-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat Spec CHA-RL1i marked as removed #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link to reference impl. in chat-js -> ably/ably-chat-js#387 |
This might need spec update for |
AndyTWF
reviewed
Nov 18, 2024
Rephrase CHA-RL1i statement Co-authored-by: Andy Ford <[email protected]>
sacOO7
requested review from
AndyTWF,
splindsay-92 and
vladvelici
and removed request for
splindsay-92
November 22, 2024 08:06
AndyTWF
reviewed
Nov 22, 2024
Rephrased as per CHA-RC1 Co-authored-by: Andy Ford <[email protected]>
AndyTWF
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rooms.get
async implrooms.get
will always return a new room or existing room ( not in releasing or released state )