Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Spec CHA-RL1i marked as removed #229

Merged
merged 4 commits into from
Nov 23, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Nov 15, 2024

  • CHA-RL1i is not needed as per latest rooms.get async impl
  • Latest rooms.get will always return a new room or existing room ( not in releasing or released state )
  • So there's no point of having a check for a previous room for channel ATTACH

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Nov 15, 2024

Link to reference impl. in chat-js -> ably/ably-chat-js#387

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Nov 15, 2024

This might need spec update for CHA-RC1 that includes explicit rooms.get and rooms.release operations

Rephrase CHA-RL1i statement

Co-authored-by: Andy Ford <[email protected]>
@sacOO7 sacOO7 marked this pull request as ready for review November 22, 2024 08:05
@sacOO7 sacOO7 requested review from AndyTWF, splindsay-92 and vladvelici and removed request for splindsay-92 November 22, 2024 08:06
Rephrased as per CHA-RC1

Co-authored-by: Andy Ford <[email protected]>
@sacOO7 sacOO7 requested a review from AndyTWF November 22, 2024 13:05
@sacOO7 sacOO7 merged commit 13c945a into main Nov 23, 2024
2 checks passed
@sacOO7 sacOO7 deleted the fix/chat-spec-room-lifecycle-attach branch November 23, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants