Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presence spec points assume ATTACHING status is always caused by an ATTACH operation #228

Closed
lawrence-forooghian opened this issue Nov 14, 2024 · 0 comments · Fixed by #232
Labels
chat Related to the Chat SDK.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Nov 14, 2024

** @(CHA-PR3d)@ @[Testable]@ If the room status is @attaching@, then the @Enter@ call will wait for the attach operation to succeed and then call the underlying presence @Enter@ operation. It will throw an error if the attach fails.

(and similar points for other places we use channel presence operations)

This assumes that a room can only be in ATTACHING because of an ATTACH operation. This is not true — it can also be in this status because:

  • a contributor entered ATTACHING and the transient disconnect timeout subsequently elapsed (CHA-RL4b7), or
  • the RETRY operation put it into ATTACHED (CHA-RL5f)

How should the CHA-PR3d wait behave in this situation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat Related to the Chat SDK.
Development

Successfully merging a pull request may close this issue.

1 participant