Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4706] fix: push notifications corner cases #994

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[ECO-4706] fix: push notifications corner cases #994

merged 1 commit into from
Apr 3, 2024

Conversation

ttypic
Copy link
Contributor

@ttypic ttypic commented Mar 20, 2024 •
edited by jira bot
Loading

Resolves #993
Jira Issue: ECO-4706

  • clear partial state when CalledDeactivate come to NotActive state
  • use only deviceIdentityToken to perform deregistration call
  • ignore errors with 401 status code and 40005 code (invalid credentials)

@ttypic ttypic changed the title fix: push notifications corner cases [ECO-4706] fix: push notifications corner cases Mar 20, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/994/features March 20, 2024 13:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/994/javadoc March 20, 2024 13:32 Inactive
@ttypic ttypic force-pushed the ECO-4706/fix-push-corner-cases branch from 9c9ee0d to ec020b2 Compare March 20, 2024 18:25
@github-actions github-actions bot temporarily deployed to staging/pull/994/features March 20, 2024 18:25 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/994/javadoc March 20, 2024 18:26 Inactive
@ttypic ttypic force-pushed the ECO-4706/fix-push-corner-cases branch from ec020b2 to cc79da5 Compare March 20, 2024 18:33
@github-actions github-actions bot temporarily deployed to staging/pull/994/features March 20, 2024 18:33 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/994/javadoc March 20, 2024 18:34 Inactive
@ttypic ttypic force-pushed the ECO-4706/fix-push-corner-cases branch from cc79da5 to 6d2a9b9 Compare March 20, 2024 18:48
@github-actions github-actions bot temporarily deployed to staging/pull/994/features March 20, 2024 18:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/994/javadoc March 20, 2024 18:50 Inactive
@ttypic ttypic force-pushed the ECO-4706/fix-push-corner-cases branch from 6d2a9b9 to fa932fb Compare March 21, 2024 01:07
@github-actions github-actions bot temporarily deployed to staging/pull/994/features March 21, 2024 01:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/994/javadoc March 21, 2024 01:08 Inactive
@ttypic ttypic force-pushed the ECO-4706/fix-push-corner-cases branch from fa932fb to ca7e4c8 Compare March 21, 2024 09:38
@github-actions github-actions bot temporarily deployed to staging/pull/994/features March 21, 2024 09:39 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/994/javadoc March 21, 2024 09:40 Inactive
@ttypic ttypic force-pushed the ECO-4706/fix-push-corner-cases branch from ca7e4c8 to 1702a72 Compare March 21, 2024 09:59
@github-actions github-actions bot temporarily deployed to staging/pull/994/features March 21, 2024 09:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/994/javadoc March 21, 2024 10:00 Inactive
@ttypic ttypic requested review from AndyTWF and paddybyers March 21, 2024 10:29
@umair-ably umair-ably mentioned this pull request Mar 27, 2024
Merged
@ttypic
fix: push notifications corner cases
d44e4f6 
- clear partial state when `CalledDeactivate` come to `NotActive` state
- use only `deviceIdentityToken` to perform deregistration call
- ignore errors with 401 status code and 40005 code (invalid credentials)
@ttypic ttypic force-pushed the ECO-4706/fix-push-corner-cases branch from 1702a72 to d44e4f6 Compare April 3, 2024 08:20
@ttypic ttypic merged commit ced191d into main Apr 3, 2024
9 checks passed
@ttypic ttypic deleted the ECO-4706/fix-push-corner-cases branch April 3, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umair-ably umair-ably umair-ably left review comments

@AndyTWF AndyTWF AndyTWF approved these changes

@paddybyers paddybyers Awaiting requested review from paddybyers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push Notification corner cases
3 participants
@ttypic @AndyTWF @umair-ably