Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for go1.23 and drop versions before 1.22 #663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amnonbc
Copy link
Contributor

@amnonbc amnonbc commented Aug 19, 2024

Go 1.23 was released last week.
We follow the Go release policy of supporting the last two versions of Go.

See https://github.com/ably/ably-go#supported-versions-of-go

@amnonbc amnonbc requested a review from sacOO7 August 19, 2024 07:04
@github-actions github-actions bot temporarily deployed to staging/pull/663/godoc August 19, 2024 07:05 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/663/features August 19, 2024 07:05 Inactive
@sacOO7
Copy link
Collaborator

sacOO7 commented Aug 19, 2024

Being active maintainer I would like to know reasons behind policy, considering there's lot of apps using older version of go and breaking changes for older versions will go undetected.

@paddybyers
Copy link
Member

We can't just drop support for older versions like that. We will use usage stats to determine who is using which versions and that will determine which versions are eligible to be dropped.

@sacOO7
Copy link
Collaborator

sacOO7 commented Aug 19, 2024

We can't just drop support for older versions like that. We will use usage stats to determine who is using which versions and that will determine which versions are eligible to be dropped.

Agreed, we don't drop older versions for other SDKs as well.

@amnonbc
Copy link
Contributor Author

amnonbc commented Aug 19, 2024

Being active maintainer I would like to know reasons behind policy, considering there's lot of apps using older version of go and breaking changes for older versions will go undetected.

Sure:
See https://go.dev/doc/devel/release#policy
and also https://go.dev/blog/compat

@paddybyers
Copy link
Member

@amnonbc lets take this offline please

@github-actions github-actions bot temporarily deployed to staging/pull/663/features August 20, 2024 09:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/663/godoc August 20, 2024 09:51 Inactive
Copy link
Collaborator

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@amnonbc
Copy link
Contributor Author

amnonbc commented Feb 3, 2025

do we want to merge this?
(I don't have permission).
Also 1.24 will be released this month.

@sacOO7
Copy link
Collaborator

sacOO7 commented Feb 3, 2025

do we want to merge this? (I don't have permission). Also 1.24 will be released this month.

Let's wait for #679 to get merged, Tests on main are failing : (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants