-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for go1.23 and drop versions before 1.22 #663
base: main
Are you sure you want to change the base?
Conversation
Being active maintainer I would like to know reasons behind policy, considering there's lot of apps using older version of go and breaking changes for older versions will go undetected. |
We can't just drop support for older versions like that. We will use usage stats to determine who is using which versions and that will determine which versions are eligible to be dropped. |
Agreed, we don't drop older versions for other SDKs as well. |
Sure: |
@amnonbc lets take this offline please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
do we want to merge this? |
Let's wait for #679 to get merged, Tests on main are failing : ( |
Go 1.23 was released last week.
We follow the Go release policy of supporting the last two versions of Go.
See https://github.com/ably/ably-go#supported-versions-of-go