Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If waiting for push device details and got them persisted, re-emit them. #967

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Jan 13, 2020

While once #966 is fixed new apps won't get into that "illegal"
persisted state, we still need to recover from it for old apps.

This also serves as a workaround, so that the "proper" fix for #966 is
not urgent.

While once #966 is fixed new apps won't get into that "illegal"
persisted state, we still need to recover from it for old apps.

This also serves as a workaround, so that the "proper" fix for #966 is
not urgent.
@tcard tcard self-assigned this Jan 13, 2020
@tcard
Copy link
Contributor Author

tcard commented Jan 13, 2020

It seems this broke some tests:

11:53:57]: ▸     ✗ Activation_state_machine__State_NotActivated__on_Event_CalledActivate__if_the_local_device_has_id_and_deviceIdentityToken_then_should_transition_to_WaitingForNewPushDeviceDetails, Test crashed

[11:53:57]: ▸     ✗ Activation_state_machine__State_WaitingForPushDeviceDetails__on_Event_GotPushDeviceDetails__should_use_custom_registerCallback_and_fire_GotDeviceRegistration_event, failed: caught "ARTPushRegistererDelegate must be implemented on AppDelegate"

[11:53:57]: ▸     ✗ Activation_state_machine__State_WaitingForPushDeviceDetails__on_Event_GotPushDeviceDetails__should_use_custom_registerCallback_and_fire_GettingDeviceRegistrationFailed_event, failed: caught "ARTPushRegistererDelegate must be implemented on AppDelegate"

[11:53:57]: ▸     ✗ Activation_state_machine__State_WaitingForPushDeviceDetails__on_Event_GotPushDeviceDetails__should_fire_GotDeviceRegistration_event, failed: caught "ARTPushRegistererDelegate must be implemented on AppDelegate"

[11:53:57]: ▸     ✗ Activation_state_machine__State_WaitingForPushDeviceDetails__on_Event_GotPushDeviceDetails__should_fire_GettingDeviceRegistrationFailed_event, failed: caught "ARTPushRegistererDelegate must be implemented on AppDelegate"

[11:53:57]: ▸     ✗ Activation_state_machine__State_WaitingForPushDeviceDetails__on_Event_GotPushDeviceDetails__should_transition_to_WaitingForDeviceRegistration, failed: caught "ARTPushRegistererDelegate must be implemented on AppDelegate"

[11:53:57]: ▸     ✗ Channel_Subscriptions__removeWhere__should_remove_by_deviceId, expected to contain <<ARTPushChannelSubscription: 0x7ffe8aa38170> -deviceId: deviceDetails2ClientA; clientId: (null);channel: pushenabled:foo;, <ARTPushChannelSubscription: 0x7ffe8aa38300> -deviceId: deviceDetails2ClientA; clientId: (null);channel: pushenabled:bar;>, got <[]>

Even though the storage gets refreshed before each test, the token is
cached in the rest instance, so other tests see it.
@tcard tcard requested a review from QuintinWillison January 13, 2020 15:18
@tcard tcard merged commit 74ada5e into develop Jan 13, 2020
@tcard tcard deleted the 966-push-illegal-states branch January 13, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants