Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ably-ios references to ably-cocoa #954

Merged
merged 6 commits into from
Feb 3, 2020
Merged

Update ably-ios references to ably-cocoa #954

merged 6 commits into from
Feb 3, 2020

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Dec 22, 2019

From #945:

  • Change default agent to ably-cocoa
  • Include a variant based on platform such as macos, ios, watchos, ipados. Not sure what the official variants are, but assuming it was ios it would be ably-cocoa.ios
  • Check for legacy references in code to ably-ios and replace with ably-cocoa

@tcard tcard self-assigned this Dec 22, 2019
@tcard tcard mentioned this pull request Dec 22, 2019
Closed
4 tasks
@tcard
Copy link
Contributor Author

tcard commented Jan 2, 2020

@mattheworiordan Please confirm we can release this without breaking any internal machinery.

@QuintinWillison QuintinWillison changed the base branch from develop to master January 31, 2020 14:39
@mattheworiordan
Copy link
Member

@tcard I am not aware of any places this will break internal machinery. As far as I am aware, we have no "hard coded" dependencies on the iOS agent string. Probably worth @SimonWoolf and/or @paddybyers confirming for sure as I don't code any of the "internal machinery" as such.

@tcard tcard requested review from paddybyers and SimonWoolf and removed request for mattheworiordan February 3, 2020 10:19
SimonWoolf
SimonWoolf previously approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@SimonWoolf SimonWoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any instance in realtime where we sniff for ios, so fine with this 👍
(not looked at the pr in detail)

@tcard tcard removed the request for review from paddybyers February 3, 2020 12:03
@tcard tcard dismissed stale reviews from SimonWoolf and QuintinWillison via 440b371 February 3, 2020 12:08
@tcard
Copy link
Contributor Author

tcard commented Feb 3, 2020

Bitrise: ✅

@tcard tcard requested a review from QuintinWillison February 3, 2020 12:35
@tcard tcard merged commit a1b04ac into master Feb 3, 2020
@tcard tcard deleted the 945-cocoa-agent branch February 3, 2020 13:28
tcard added a commit that referenced this pull request Feb 8, 2020
@tcard
Fix bad merge in README.
84600a6 
#954 included a bad merge in the README.
@tcard tcard mentioned this pull request Feb 8, 2020
Merged
QuintinWillison pushed a commit that referenced this pull request Feb 8, 2020
@tcard
Fix bad merge in README.
692cdd1 
#954 included a bad merge in the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@SimonWoolf SimonWoolf SimonWoolf left review comments

Assignees

@tcard tcard

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcard @mattheworiordan @SimonWoolf @QuintinWillison