Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection SUSPENDED timeout #917

Merged
merged 18 commits into from
Jan 22, 2020
Merged

Fix connection SUSPENDED timeout #917

merged 18 commits into from
Jan 22, 2020

Conversation

ricardopereira
Copy link
Contributor

Copy link
Contributor

@tcard tcard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the hard feedback on such an old PR! We can discuss this more constructively if you want when you're back.

Spec/RealtimeClientConnection.swift Outdated Show resolved Hide resolved
Spec/RealtimeClientConnection.swift Outdated Show resolved Hide resolved
Spec/RealtimeClientConnection.swift Outdated Show resolved Hide resolved
Spec/TestUtilities.swift Outdated Show resolved Hide resolved
Source/ARTRealtime.m Outdated Show resolved Hide resolved
Source/ARTRealtime.m Outdated Show resolved Hide resolved
Source/ARTRealtime.m Outdated Show resolved Hide resolved
Source/ARTRealtime.m Outdated Show resolved Hide resolved
@ricardopereira ricardopereira changed the base branch from fix-881 to develop January 6, 2020 11:41
@ricardopereira ricardopereira requested a review from tcard January 17, 2020 09:28
@ricardopereira
Copy link
Contributor Author

@tcard Can you please check my changes? Thanks

Source/ARTRealtime+Private.h Outdated Show resolved Hide resolved
Source/ARTRealtime.m Outdated Show resolved Hide resolved
Source/ARTRealtime.m Outdated Show resolved Hide resolved
Source/ARTRealtime.m Outdated Show resolved Hide resolved
@ricardopereira ricardopereira merged commit 82a5733 into develop Jan 22, 2020
@ricardopereira ricardopereira deleted the fix-913 branch January 22, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants