Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NSData.description to stringify device tokens correctly #893

Merged
merged 4 commits into from
Sep 20, 2019
Merged

Replace NSData.description to stringify device tokens correctly #893

merged 4 commits into from
Sep 20, 2019

Conversation

ricardopereira
Copy link
Contributor

Fix #889.

paddybyers
paddybyers reviewed Sep 19, 2019
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this have an impact on devices where the token is already persisted? Ie will the new code be able to read tokens that were persisted with the old code?

@ricardopereira
Copy link
Contributor Author

@paddybyers Yes, it's compatible with older versions.

paddybyers
paddybyers approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ricardopereira ricardopereira changed the base branch from push-log-entries to develop September 20, 2019 13:01
@ricardopereira ricardopereira merged commit 425e2ec into develop Sep 20, 2019
@ricardopereira ricardopereira deleted the fix-push-device-token branch September 20, 2019 13:02
ricardopereira added a commit that referenced this pull request Oct 3, 2019
@ricardopereira
Replace NSData.description to stringify device tokens correctly #893
3bc4b8d 
Squashed:
 - TestSuite: MockDeviceStorage should store values that were written
 - Test for #889: should store the device token data as string
 - Fix #889: NSData.description is not a good way to stringify device tokens and it will break in iOS 13
 - Test suite: fix intermittent failure of "ARTPushRegistererDelegate must be implemented"
This was referenced Dec 4, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push token: replace NSData.description usage
2 participants
@ricardopereira @paddybyers