Push Device Update Registration: fix request authentication #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted when there's a deviceIdentityToken in the response.
- The respond body from PATCH /push/deviceRegistrations/{deviceId} has not 'deviceIdentityToken' field.
…no 'deviceIdentityToken' field.
|
I'll clean this mess and rebase. |
ricardopereira
force-pushed
the
fix-push-auth-update-registration
branch
from
2b74677 to
7f112d3
Compare
paddybyers
requested changes
Jul 3, 2019
| let authorization = request.allHTTPHeaderFields?["X-Ably-DeviceIdentityToken"] | ||
| expect(authorization).to(equal(testIdentityTokenDetails.token.base64Encoded())) | ||
| expect(request.allHTTPHeaderFields?["Authorization"]).toNot(beNil()) | ||
| let deviceAuthorization = request.allHTTPHeaderFields?["X-Ably-DeviceIdentityToken"] |
There was a problem hiding this comment.
Still lots of references to this header. These should all be updated to X-Ably-DeviceToken. (That's not what the spec says, but that's what's implemented in the system, so we will update those as a separate piece of work.)
There was a problem hiding this comment.
Done 256c1e5. Thanks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deviceUpdateRegistrationmethod was setting a wrong Authorization header and was trying to read an updateddeviceIdentityTokenfrom the response body. Since that field doesn't exist, the localdeviceIdentityTokenDetailswas updated with atoken=nil.