Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4873] Max message size fix #1947

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[ECO-4873] Max message size fix #1947

merged 2 commits into from
Jul 18, 2024

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Jul 12, 2024

Closes #1945 and #1946

maxMessageSize wasn't properly respected across the codebase. This fix adds different default values for production/sandbox and properly propogates appropriate value to calculation sites.

@github-actions github-actions bot temporarily deployed to staging/pull/1947/features July 12, 2024 15:40 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1947/jazzydoc July 12, 2024 15:43 Inactive
@maratal maratal force-pushed the fix/1945-max-message-size branch from 84daa5d to 0a70feb Compare July 13, 2024 23:14
@github-actions github-actions bot temporarily deployed to staging/pull/1947/features July 13, 2024 23:15 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1947/jazzydoc July 13, 2024 23:18 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1947/features July 13, 2024 23:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1947/jazzydoc July 13, 2024 23:37 Inactive
@maratal maratal marked this pull request as ready for review July 14, 2024 00:28
@maratal maratal requested a review from umair-ably July 14, 2024 00:28
@maratal maratal force-pushed the fix/1945-max-message-size branch from 9c9a3d9 to 33981e8 Compare July 14, 2024 01:45
@github-actions github-actions bot temporarily deployed to staging/pull/1947/features July 14, 2024 01:46 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1947/jazzydoc July 14, 2024 01:49 Inactive
@maratal maratal force-pushed the fix/1945-max-message-size branch from 33981e8 to ff1fbf6 Compare July 14, 2024 12:25
@github-actions github-actions bot temporarily deployed to staging/pull/1947/features July 14, 2024 12:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1947/jazzydoc July 14, 2024 12:28 Inactive
maratal added 2 commits July 14, 2024 17:05
… fix adds different default values for production/sandbox and properly propogates appropriate value to calculation sites.
Copy link
Contributor

@umair-ably umair-ably left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment which mentions where these limits come from would be useful - LGTM otherwise 🚀

@maratal maratal merged commit 296361c into main Jul 18, 2024
7 checks passed
@maratal maratal deleted the fix/1945-max-message-size branch July 18, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Changed in maximum message length
2 participants