Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4838] Attach according to RTL7c #1935

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Jun 16, 2024

Closes #1934

@github-actions github-actions bot temporarily deployed to staging/pull/1935/features June 16, 2024 12:36 Inactive
@maratal maratal changed the title Channel now will be attached whenever subscribe is called. [ECO-4838] Channel now will be attached whenever subscribe is called. Jun 16, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/1935/jazzydoc June 16, 2024 12:39 Inactive
@maratal maratal marked this pull request as ready for review June 16, 2024 13:11
@maratal maratal requested review from sacOO7 and umair-ably June 16, 2024 13:11
umair-ably
umair-ably previously approved these changes Jun 28, 2024
@maratal maratal force-pushed the fix/1934-attach-when-subscribe branch from 5c0a177 to 4635dca Compare July 1, 2024 00:45
@maratal maratal changed the title [ECO-4838] Channel now will be attached whenever subscribe is called. [ECO-4838] Attach according to RTL7c Jul 1, 2024
@maratal maratal requested a review from umair-ably July 1, 2024 00:46
@maratal maratal dismissed umair-ably’s stale review July 1, 2024 00:47

Needs re-revew due to changed implementation.

@maratal maratal merged commit da113e8 into main Jul 3, 2024
7 checks passed
@maratal maratal deleted the fix/1934-attach-when-subscribe branch July 3, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Channel attach conditions
2 participants