Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4698] Fix presence according to reference implementation #1891

Merged
merged 17 commits into from
Apr 16, 2024
Merged

[ECO-4698] Fix presence according to reference implementation #1891

merged 17 commits into from
Apr 16, 2024

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Mar 17, 2024

Closes #1890

@github-actions github-actions bot temporarily deployed to staging/pull/1891/features March 17, 2024 22:25 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc March 17, 2024 22:29 Inactive
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from 15c6bc7 to d560475 Compare March 17, 2024 23:37
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features March 17, 2024 23:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc March 17, 2024 23:40 Inactive
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from d560475 to 515db0f Compare March 17, 2024 23:48
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features March 17, 2024 23:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc March 17, 2024 23:52 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features March 18, 2024 00:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc March 18, 2024 00:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features March 19, 2024 00:09 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc March 19, 2024 00:12 Inactive
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from b0392fd to 674eea5 Compare March 19, 2024 00:53
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features March 19, 2024 00:53 Inactive
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from 674eea5 to 2ee0ef7 Compare March 19, 2024 00:57
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features March 19, 2024 00:57 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc March 19, 2024 01:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features March 19, 2024 12:56 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc March 19, 2024 12:59 Inactive
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from ad4d653 to b98d6b3 Compare March 19, 2024 14:19
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features March 19, 2024 14:20 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc March 19, 2024 14:23 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features March 20, 2024 21:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features April 7, 2024 21:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc April 7, 2024 21:48 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features April 12, 2024 15:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc April 12, 2024 15:58 Inactive
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from 9050d5d to 81e0a98 Compare April 13, 2024 17:41
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features April 13, 2024 17:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc April 13, 2024 17:45 Inactive
@maratal
Fail publish presence according to RTP16b/RTP16c (Removed RTP10a TODO…
81ef883 
… as it is not needed, since realtime already sends previously set data value).
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from 81e0a98 to 81ef883 Compare April 13, 2024 20:59
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features April 13, 2024 20:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc April 13, 2024 21:04 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features April 13, 2024 23:06 Inactive
@github-actions github-actions bot requested a deployment to staging/pull/1891/jazzydoc April 13, 2024 23:10 In progress
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from 45ae6e1 to a5e84f4 Compare April 13, 2024 23:12
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features April 13, 2024 23:13 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc April 13, 2024 23:17 Inactive
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from a5e84f4 to 5cbaad3 Compare April 13, 2024 23:22
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features April 13, 2024 23:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc April 13, 2024 23:27 Inactive
@maratal maratal mentioned this pull request Apr 14, 2024
Closed
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from 5cbaad3 to a547724 Compare April 14, 2024 13:06
@github-actions github-actions bot temporarily deployed to staging/pull/1891/features April 14, 2024 13:06 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1891/jazzydoc April 14, 2024 13:13 Inactive
@maratal maratal force-pushed the fix/1890-update-presence-to-ref-impl branch from a547724 to 81ef883 Compare April 14, 2024 13:58
sacOO7
sacOO7 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maratal maratal merged commit b8b3d44 into main Apr 16, 2024
13 of 14 checks passed
@maratal maratal deleted the fix/1890-update-presence-to-ref-impl branch April 16, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacOO7 sacOO7 sacOO7 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix presence implementation according to reference one (ably-go)
2 participants
@maratal @sacOO7