Experimental #1854
Closed
Experimental #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n activate) and initialising `clientId` at the same moment (RSH8b). Device's `id` and `secret` no longer are being generated lazily on the first call (RSH8a). I didn't touch any threading code here on purpose, since this PR is already complex enough.
Many tests relied on device details were there by default, so the only way to supply the details there (without proper state machine activation sequence) is to artificially call the `setupLocalDevice()`.
…e deviceSecret (due to wrong spec PCD2 which draws id as not nullable).
This reverts commit a6e39f7.
This reverts commit 7fbbc50.
github-actions
bot
temporarily deployed
to
staging/pull/1854/features
github-actions
bot
temporarily deployed
to
staging/pull/1854/jazzydoc
github-actions
bot
temporarily deployed
to
staging/pull/1854/features
github-actions
bot
temporarily deployed
to
staging/pull/1854/jazzydoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1847