Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.2.23 #1835

Merged
merged 2 commits into from
Nov 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Change Log

## [1.2.23](https://github.com/ably/ably-cocoa/tree/1.2.23)

[Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.22...1.2.23)

**Fixed issues:**

- Push device deregistration does not clear device details. [\#1177](https://github.com/ably/ably-cocoa/issues/1177)
- App build fails due to missing dependencies. [\#1755](https://github.com/ably/ably-cocoa/issues/1755) and [\#1824](https://github.com/ably/ably-cocoa/issues/1824)

## [1.2.22](https://github.com/ably/ably-cocoa/tree/1.2.22)

[Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.21...1.2.22)
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ You can install Ably for iOS and macOS through Package Manager, CocoaPods, Carth
- [This apple guide](https://developer.apple.com/documentation/swift_packages/adding_package_dependencies_to_your_app) explains the steps in more detail.
- To install the `ably-cocoa` package in another **Swift Package**, then add the following to your `Package.Swift`:
```swift
.package(url: "https://github.com/ably/ably-cocoa", from: "1.2.22"),
.package(url: "https://github.com/ably/ably-cocoa", from: "1.2.23"),
```
### Installing through [CocoaPods](https://cocoapods.org/)

Expand Down Expand Up @@ -101,7 +101,7 @@ If you see, for example, a `dyld: Library not loaded: @rpath/AblyDeltaCodec.fram

### Manual installation

1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.22), or clone it to get the latest, unstable and possibly underdocumented version: `git clone [email protected]:ably/ably-cocoa.git`
1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.23), or clone it to get the latest, unstable and possibly underdocumented version: `git clone [email protected]:ably/ably-cocoa.git`
2. Drag the directory `ably-cocoa/ably-cocoa` into your project as a group.
3. Ably depends on our [MessagePack Fork](https://github.com/ably-forks/msgpack-objective-C) 0.2.0; get it [from the releases page](https://github.com/ably-forks/msgpack-objective-C/releases/tag/0.2.0-ably-1) and link it into your project.

Expand Down
2 changes: 1 addition & 1 deletion Scripts/jazzy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jazzy \
--objc \
--clean \
--author Ably \
--module-version 1.2.22 \
--module-version 1.2.23 \
--umbrella-header Source/include/Ably/Ably.h \
--framework-root Source \
--module Ably \
Expand Down
2 changes: 1 addition & 1 deletion Source/ARTClientInformation.m
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#import <sys/utsname.h>

NSString *const ARTClientInformationAgentNotVersioned = @"ARTClientInformationAgentNotVersioned";
NSString *const ARTClientInformation_libraryVersion = @"1.2.22";
NSString *const ARTClientInformation_libraryVersion = @"1.2.23";
static NSString *const _libraryName = @"ably-cocoa";

// NSOperatingSystemVersion has NSInteger as version components for some reason, so mitigate it here.
Expand Down
2 changes: 1 addition & 1 deletion Test/Tests/ARTDefaultTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ class ARTDefaultTests: XCTestCase {

func testVersions() {
XCTAssertEqual(ARTDefault.apiVersion(), "1.2")
XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.22")
XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.23")
}
}
6 changes: 3 additions & 3 deletions Test/Tests/ClientInformationTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ final class ClientInformationTests: XCTestCase {

XCTAssertEqual(agents.keys.count, 2)

XCTAssertEqual(agents["ably-cocoa"], "1.2.22")
XCTAssertEqual(agents["ably-cocoa"], "1.2.23")

#if os(iOS)
XCTAssertTrue(agents.keys.contains("iOS"))
Expand All @@ -27,7 +27,7 @@ final class ClientInformationTests: XCTestCase {
// CR3, CR3b
func testAgentIdentifierWithAdditionalAgents_withNilAdditionalAgents() {
let expectedIdentifier = [
"ably-cocoa/1.2.22",
"ably-cocoa/1.2.23",
ARTDefault.platformAgent()
].sorted().joined(separator: " ")

Expand All @@ -42,7 +42,7 @@ final class ClientInformationTests: XCTestCase {
]

let expectedIdentifier = [
"ably-cocoa/1.2.22",
"ably-cocoa/1.2.23",
"demolib/0.0.1",
"morelib",
ARTDefault.platformAgent()
Expand Down
2 changes: 1 addition & 1 deletion Test/Tests/RealtimeClientConnectionTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ class RealtimeClientConnectionTests: XCTestCase {
done()
case .connected:
if let transport = client.internal.transport as? TestProxyTransport, let query = transport.lastUrl?.query {
expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.22"))
expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.23"))
} else {
XCTFail("MockTransport isn't working")
}
Expand Down
2 changes: 1 addition & 1 deletion Test/Tests/RestClientTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1734,7 +1734,7 @@ class RestClientTests: XCTestCase {
let headerAgent = testHTTPExecutor.requests.first!.allHTTPHeaderFields?["Ably-Agent"]
let ablyAgent = ARTClientInformation.agentIdentifier(withAdditionalAgents: options.agents)
XCTAssertEqual(headerAgent, ablyAgent)
XCTAssertTrue(headerAgent!.hasPrefix("ably-cocoa/1.2.22"))
XCTAssertTrue(headerAgent!.hasPrefix("ably-cocoa/1.2.23"))
done()
}
}
Expand Down
2 changes: 1 addition & 1 deletion Version.xcconfig
Original file line number Diff line number Diff line change
@@ -1 +1 @@
CURRENT_PROJECT_VERSION = 1.2.22
CURRENT_PROJECT_VERSION = 1.2.23
Loading