Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing strong property attributes #1434

Merged
merged 4 commits into from
Jun 16, 2022
Merged

Added missing strong property attributes #1434

merged 4 commits into from
Jun 16, 2022

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Jun 15, 2022 •
edited
Loading

Closes #1433, #1435

QuintinWillison
QuintinWillison suggested changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In particular for synthesised properties, I think we should prefer copy over strong where the type has a mutable counterpart.

Source/ARTDeviceDetails.h Outdated Show resolved Hide resolved
@maratal maratal mentioned this pull request Jun 15, 2022
Closed
@QuintinWillison QuintinWillison linked an issue Jun 15, 2022 that may be closed by this pull request
Mutable ARTDeviceDetails.metadata #1435
Closed
@maratal maratal requested a review from QuintinWillison June 15, 2022 14:27
@maratal maratal merged commit b2942bd into main Jun 16, 2022
@maratal maratal deleted the fix/1433-explicit-strong-properties branch June 16, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@lawrence-forooghian lawrence-forooghian Awaiting requested review from lawrence-forooghian

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mutable ARTDeviceDetails.metadata Multiple warnings generated by jazzy command:
2 participants
@maratal @QuintinWillison