Replace ?-chains with force-unwraps. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests seem to be failing due to what #139 is supposed to fix. |
|
Agreed, 👍 |
There is some abuse of ?-chaining in the test code. If we expect a thing to be there and if not being that the case would mean that test code (e. g. a helper) is wrong, force-unwrap should be used instead of silently ignoring this condition with a ?-chain so that the error is caught from the test framework. The test framework should only tell us about the code being tested, not about the code that tests the code being tested.
tcard
force-pushed
the
replace-chains-unwrap
branch
from
4147775 to
0a0488e
Compare
|
LGTM |
tcard
added a commit
that referenced
this pull request
Jan 20, 2016
Replace ?-chains with force-unwraps.
maratal
pushed a commit
that referenced
this pull request
Jul 19, 2023
Spec: add RTP2b1a to clarify edge-case in newness comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some abuse of ?-chaining in the test code. If we expect a
thing to be there and if not being that the case would mean that
test code (e. g. a helper) is wrong, force-unwrap should be used
instead of silently ignoring this condition with a ?-chain so that
the error is caught from the test framework. The test framework
should only tell us about the code being tested, not about the
code that tests the code being tested.