Remove KSCrash and unhandled exception handlers #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1068. Relates to #949.
KSCrash and Sentry were added in #599 and #603 (early 2017) but things have moved on a lot since then in terms of library stability, as well as in respect of the expectations of developers integrating our library into their apps - as well as their libraries in some cases!
Our library has no need to be catching exceptions. It counts as unexpected (not idiomatic) behaviour. If an app developer wishes to catch exceptions then they can engineer that themselves for the app process, choosing their own approach to logging them in accordance with their terms and conditions agreed with their users.