Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite: keep channel name prefix for current ClientOptions while calling 'setupOptions' and other improvements #1009

Merged
merged 6 commits into from
Apr 8, 2020

Conversation

ricardopereira
Copy link
Contributor

No description provided.

time it was called and it's not the best approach for tests that are
running in parallel. Example: one test is expecting a channel named
'test-13-foo' but another test is calling 'setupOptions' and the
prefix changes to 'test-14-foo' which could break the first test
if a 'channels.get' is called and it's expecting 'test-13-foo'.

Now we have a new private property in ClientOptions called
'channelNamePrefix'. It's nil by default but the Test Suite, more
precisely 'setupOptions', will increment the 'channelNamePrefix' to
avoid name clashes while running the whole test suite.
@@ -363,7 +363,7 @@ -(void)invokeWithResult:(const id)result error:(NSError *const)error {
}

if (callback) {
_callback(result, error);
callback(result, error);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small but important fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 .... 😌

@ricardopereira ricardopereira merged commit 86e85ae into master Apr 8, 2020
@ricardopereira ricardopereira deleted the fix-testsuite branch April 8, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants