Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old push state AfterRegistrationUpdateFailed needs migration #993

Closed
tcard opened this issue Feb 26, 2020 · 0 comments · Fixed by #994
Closed

Old push state AfterRegistrationUpdateFailed needs migration #993

tcard opened this issue Feb 26, 2020 · 0 comments · Fixed by #994
Assignees
@tcard
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@tcard
Copy link
Contributor

tcard commented Feb 26, 2020

While talking to @QuintinWillison I noticed that now that we've renamed AfterRegistrationUpdateFailed to AfterRegistrationSyncFailed, if clients update were to update the library where the previous persistent state was AfterRegistrationUpdateFailed, loading the state from persistence would fail, as no such state exists now. We need to make sure we upgrade deprecated states to their new counterparts.
@tcard tcard added the bug Something isn't working. It's clear that this does need to be fixed. label Feb 26, 2020
@tcard tcard self-assigned this Feb 26, 2020
tcard added a commit that referenced this issue Feb 27, 2020
@tcard
Migrate persisted AfterRegistrationUpdateFailed to ...SyncFailed.
5755078 
Fixes #993.
@tcard tcard mentioned this issue Feb 27, 2020
Merged
tcard added a commit that referenced this issue Feb 27, 2020
@tcard
Migrate persisted AfterRegistrationUpdateFailed to ...SyncFailed. (#994)
8090611 
Fixes #993.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcard tcard

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate persisted AfterRegistrationUpdateFailed to ...SyncFailed. ably/ably-cocoa
1 participant
@tcard