Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ably requests include incomplete header values. #530

Closed
aquigriffin opened this issue Nov 11, 2016 · 1 comment
Closed

Ably requests include incomplete header values. #530

aquigriffin opened this issue Nov 11, 2016 · 1 comment

Comments

@aquigriffin
Copy link

Found requesting a token with a valid token_request, the network call made by the Ably SDK includes a header as follows:

X-Ably-Lib: ios-(null)

Please make sure the header does not include a null value.
@mattheworiordan
Copy link
Member

Thanks @aquigriffin, sounds like a new-ish issue as we only introduce version headers recently. We'll get this fixed Monday.

tcard added a commit that referenced this issue Nov 13, 2016
@tcard
Don't read library version from bundle.
4a58f65 
It's not available when the library is used from another bundle.

Fixes #530.
@tcard tcard mentioned this issue Nov 13, 2016
Merged
tcard added a commit that referenced this issue Nov 13, 2016
@tcard
Don't read library version from bundle. (#532)
1570a4e 
It's not available when the library is used from another bundle.

Fixes #530.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @aquigriffin