Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all calls to NSLog with calls to the ARTLog instance #1554

Closed
lawrence-forooghian opened this issue Dec 7, 2022 · 1 comment · Fixed by #1555
Closed

Replace all calls to NSLog with calls to the ARTLog instance #1554

lawrence-forooghian opened this issue Dec 7, 2022 · 1 comment · Fixed by #1555
Assignees
@lawrence-forooghian

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Dec 7, 2022 •
edited by sync-by-unito bot
Loading

We have some places in the codebase where we are calling NSLog instead of using the logger that was passed in to ClientOptions. We need to fix these.
@lawrence-forooghian lawrence-forooghian self-assigned this Dec 7, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 7, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3156

@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 7, 2022
Closed
lawrence-forooghian added a commit that referenced this issue Dec 7, 2022
@lawrence-forooghian
Remove usage of NSLog in SocketRocket code
b4e8375 
Replace it with calls to an ARTLog instance.

Closes #1554.
lawrence-forooghian added a commit that referenced this issue Dec 7, 2022
@lawrence-forooghian
Remove usage of NSLog in SocketRocket code
7de492f 
Replace it with calls to an ARTLog instance.

Closes #1554.

TODO notes about the build settings and how might be better solved by
moving SocketRocket code into Source
lawrence-forooghian added a commit that referenced this issue Dec 7, 2022
@lawrence-forooghian
Remove usage of NSLog in SocketRocket code
d72a80e 
Replace it with calls to an ARTLog instance.

Closes #1554.
@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 7, 2022
Merged
lawrence-forooghian added a commit that referenced this issue Dec 7, 2022
@lawrence-forooghian
Remove usage of NSLog in SocketRocket code
ca3c92e 
Replace it with calls to an ARTLog instance.

Closes #1554.
lawrence-forooghian added a commit that referenced this issue Dec 7, 2022
@lawrence-forooghian
Remove usage of NSLog in SocketRocket code
c43f04d 
Replace it with calls to an ARTLog instance.

Closes #1554.
lawrence-forooghian added a commit that referenced this issue Dec 7, 2022
@lawrence-forooghian
Remove usage of NSLog in SocketRocket code
527abca 
Replace it with calls to an ARTLog instance.

Closes #1554.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove direct calls to NSLog ably/ably-cocoa
1 participant
@lawrence-forooghian