Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in [ARTSRProxyConnect _failWithError] #1437

Open
TankKuo opened this issue Jun 20, 2022 · 6 comments · May be fixed by #1493
Open

Crash in [ARTSRProxyConnect _failWithError] #1437

TankKuo opened this issue Jun 20, 2022 · 6 comments · May be fixed by #1493
Assignees
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@TankKuo
Copy link

TankKuo commented Jun 20, 2022

Which version of the Ably SDK are you using?

1.2.10

On which platform does the issue happen?

iOS 14 ~ 15.1

Are you using Cocoapods?

If yes, specify the version (pod 'Ably', '1.2.10')

Which version of Xcode are you using?

({{ 13.2.1 (13C100)}})

The problem is that I cannot reproduce it.

Crashed: io.ably.socketrocket.NetworkThread
0 libobjc.A.dylib 0x21e0 objc_msgSend + 32
1 Story17 0x1534880 -[ARTSRProxyConnect _failWithError:] + 140 (ARTSRProxyConnect.m:140)
2 Story17 0x1535894 -[ARTSRProxyConnect stream:handleEvent:] + 362 (ARTSRProxyConnect.m:362)
3 CoreFoundation 0xc080c _signalEventSync + 216
4 CoreFoundation 0xbfccc _cfstream_shared_signalEventSync + 392
5 CoreFoundation 0xa3990 CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION

  • 28

6 CoreFoundation 0xa388c __CFRunLoopDoSource0 + 208
7 CoreFoundation 0xa2b90 __CFRunLoopDoSources0 + 268
8 CoreFoundation 0x9cb70 __CFRunLoopRun + 820
9 CoreFoundation 0x9c308 CFRunLoopRunSpecific + 600
10 Foundation 0x8d8c -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 232
11 Story17 0x15363cc -[ARTSRRunLoopThread main] + 70 (ARTSRRunLoopThread.m:70)
12 Foundation 0x17a30c NSThread__start + 864
13 libsystem_pthread.dylib 0x1bfc _pthread_start + 320
14 libsystem_pthread.dylib 0xa758 thread_start + 8

┆Issue is synchronized with this Jira Bug by Unito

@ably ably deleted a comment from sync-by-unito bot Aug 25, 2022
@ably ably deleted a comment from sync-by-unito bot Aug 25, 2022
maratal added a commit that referenced this issue Sep 5, 2022
Explanation:
`ARTSRProxyConnect` object can potentially generate a proxy connection error even after initial success (or more than one error in a raw), which can depend on what proxy type is used, which will create a race condition: `self->_proxyConnect = nil;` deallocates `ARTSRProxyConnect` object on a `_workQueue`, and a subsequent call to `_failWithError:`  on a `io.ably.socketrocket.NetworkThread` inside `ARTSRProxyConnect` will cause crash when it'll try to access `self`.
@ably ably deleted a comment from sync-by-unito bot Sep 14, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Sep 21, 2022

➤ Sara Giro commented:

Marat confimed he is looking into this today

https://ably-real-time.slack.com/archives/CSQEKCE81/p1663758966071679?thread_ts=1661334763.000079&cid=CSQEKCE81 ( https://ably-real-time.slack.com/archives/CSQEKCE81/p1663758966071679?thread_ts=1661334763.000079&cid=CSQEKCE81|smart-link )

Marat Alekperov  1 hour ago ( https://ably-real-time.slack.com/archives/CSQEKCE81/p1663758966071679?thread_ts=1661334763.000079&cid=CSQEKCE81 )
@sara Giro ( https://ably-real-time.slack.com/team/U029HTWSDSM ) I'll take a look on this in depth today, but it will take some time - to build an example app and play with it until it crashed similarly

Sara Giro  1 hour ago ( https://ably-real-time.slack.com/archives/CSQEKCE81/p1663759169025439?thread_ts=1661334763.000079&cid=CSQEKCE81 )
Many thanks @Marat Alekperov ( https://ably-real-time.slack.com/team/U021EU5U02F )

much appreciated. Please let us know when you have any info

maratal added a commit that referenced this issue Sep 27, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Nov 8, 2022

➤ Sara Giro commented:

Closing Hubspot ticket ( https://app.hubspot.com/contacts/6939709/ticket/916965781/ ) for this as discussed in our Standup today. Leaving this one open for now in case more actions are required.

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 8, 2022

➤ Vincent Pericard commented:

Thanks Sara Giro - Makes sense to close HS but keep this one open.
I’m currently monitoring this one with them and I’ve asked them for an update

Here is my latest slack message to them - sent 07/11 - https://ably-real-time.slack.com/archives/C027Q92PJB1/p1667815363391519?thread_ts=1653058507.277489&cid=C027Q92PJB1 ( https://ably-real-time.slack.com/archives/C027Q92PJB1/p1667815363391519?thread_ts=1653058507.277489&cid=C027Q92PJB1|smart-link )

@sync-by-unito sync-by-unito bot added the bug Something isn't working. It's clear that this does need to be fixed. label Jan 23, 2023
@lawrence-forooghian
Copy link
Collaborator

I think this might have been accidentally closed as part of Unito sync issues. Reopening.

@jamienewcomb
Copy link
Member

Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

Successfully merging a pull request may close this issue.

5 participants