Push device deregistration does not clear/ reset device details

[ben-xD]

This is quite low priority, but here it is:

As per RSH3g2a:

On On event Deregistered, Clears all local DeviceDetails.

Unfortunately, ably-cocoa does not clear local device details.

In Java, this can be seen by:
https://github.com/ably/ably-java/blob/2b8e3c7e65ee7109f225cad115df38d61869fc3f/android/src/main/java/io/ably/lib/push/ActivationStateMachine.java#L483

Ably-cocoa does not even have a method to reset the device details, and so is definitely not calling this.

This can be seen functionality in the Ably flutter app, in the following recording:

Screen.Recording.2021-09-14.at.15.03.47.mov

• On the left is Ably-flutter running on Android. I activate and deactivate, and the device details clearly changes.
• On the right is Ably-flutter running on iOS, and activation/ deactivation doesn't change the device details.
• iOS 🐛: When deactivating the device, the LocalDevice should be reset. It should not keep the same local device information. This means the deviceId and APNs device token (registration tokens on Android) could be different. The APNs device token on iOS and FCM registration token on Android remains the same. A different APNs device token might be possible on iOS, potentially by calling unregisterForRemoteNotifications. You could test this.

Note on the flutter app: The app is just calling the device method to show the device information.

┆Issue is synchronized with this Jira Bug by Unito

[maratal]

Isn't [local setAndPersistIdentityTokenDetails:nil]; in ARTPushActivationStateWaitingForDeregistration:transition is for?

[ben-xD]

I'm not sure what you're saying @maratal, can you clarify? 🙂

[maratal]

@ben-xD couldn't you play with PR branch? push-interactive-app is so lame, it requires a lot of work to fix it (I'm into it now). Thanks.

[ben-xD]

I initially didn't understand Marat's comments but he clarified it with me.

Isn't [local setAndPersistIdentityTokenDetails:nil]; in ARTPushActivationStateWaitingForDeregistration:transition is for?

He said this is an outdated comment and not relevant anymore.

@ben-xD couldn't you play with PR branch? push-interactive-app is so lame, it requires a lot of work to fix it (I'm into it now). Thanks.

He wants me to test it in Ably-Flutter because https://github.com/ably/push-example-ios is not well written, and we definitely agree it needs significant improvements.

[maratal]

Reopening due to #1272

[maratal]

Partially fixed by #1832