Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that reaction headers and metadata are working #198

Closed
lawrence-forooghian opened this issue Dec 16, 2024 · 1 comment · Fixed by #199
Closed

Check that reaction headers and metadata are working #198

lawrence-forooghian opened this issue Dec 16, 2024 · 1 comment · Fixed by #199
Assignees
@lawrence-forooghian
Labels
bug Something isn’t working. It’s clear that this does need to be fixed.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Dec 16, 2024 •
edited by sync-by-unito bot
Loading

Now that I’ve done #193, I suspect that we have a similar issue for reactions.

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian self-assigned this Dec 16, 2024
@lawrence-forooghian
Copy link
Collaborator Author

Yep, it's crashing.

@lawrence-forooghian lawrence-forooghian added the bug Something isn’t working. It’s clear that this does need to be fixed. label Dec 16, 2024
lawrence-forooghian added a commit that referenced this issue Dec 16, 2024
@lawrence-forooghian
Fix sending and receiving of reaction metadata and headers
ad6b02b 
Similar issue to the one which was fixed in 7fcab5c.

Haven’t added tests for the handling of the incoming message, since
there were existing tests to update; will leave this for whoever writes
these tests in #88.

The approach that I’ve taken here of using a DTO is consistent with the
approach that we use for presence data. I should have done this in
7fcab5c too; will do it separately.

TODO add tests for DTO

Resolves #198.
lawrence-forooghian added a commit that referenced this issue Dec 16, 2024
@lawrence-forooghian
Fix sending and receiving of reaction metadata and headers
f2a4722 
Similar issue to the one which was fixed in 7fcab5c.

Haven’t added tests for the handling of the incoming message, since
there were no existing tests to update and I didn’t feel like writing
them; will leave this for whoever writes these tests in #88.

The approach that I’ve taken here of using a DTO is consistent with the
approach that we use for presence data. I should have done this in
7fcab5c too; will do it separately.

Resolves #198.
lawrence-forooghian added a commit that referenced this issue Dec 16, 2024
@lawrence-forooghian
Fix sending and receiving of reaction metadata and headers
c765a06 
Similar issue to the one which was fixed in 7fcab5c.

Haven’t added tests for the handling of the incoming message, since
there were no existing tests to update and I didn’t feel like writing
them; will leave this for whoever writes these tests in #88.

The approach that I’ve taken here of using a DTO is consistent with the
approach that we use for presence data. I should have done this in
7fcab5c too; will do it separately.

TODO where has the behaviour of absent / present keys come from?

Resolves #198.
@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
bug Something isn’t working. It’s clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ECO-5181] Fix sending and receiving of reaction metadata and headers ably/ably-chat-swift
1 participant
@lawrence-forooghian