Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait-to-be-able-to-presence: throw RoomInInvalidState instead of 40000 #151

Closed
lawrence-forooghian opened this issue Nov 26, 2024 · 1 comment · Fixed by #163
Closed

wait-to-be-able-to-presence: throw RoomInInvalidState instead of 40000 #151

lawrence-forooghian opened this issue Nov 26, 2024 · 1 comment · Fixed by #163
Assignees
@lawrence-forooghian
Labels
room-lifecycle Related to room lifecycle (temporary label).

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Nov 26, 2024 •
edited by sync-by-unito bot
Loading

Split from #66.

CHA-PR3f and CHA-PR3g have been replaced by CHA-PR3h, which says to use a RoomInInvalidState error instead of a 40000 (note that there’s a different status code to the other place we throw RoomInInvalidState; see this convo)

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian added the room-lifecycle Related to room lifecycle (temporary label). label Nov 26, 2024
@lawrence-forooghian lawrence-forooghian mentioned this issue Nov 27, 2024
Closed
@lawrence-forooghian lawrence-forooghian self-assigned this Nov 27, 2024
@jamienewcomb
Copy link
Member

comment for jira

lawrence-forooghian added a commit that referenced this issue Nov 28, 2024
@lawrence-forooghian
Implement CHA-PR3h and similar
7a0952e 
Resolves #151.
@lawrence-forooghian lawrence-forooghian mentioned this issue Nov 28, 2024
Merged
lawrence-forooghian added a commit that referenced this issue Nov 28, 2024
@lawrence-forooghian
Implement CHA-PR3h and similar
951e66b 
Resolves #151.
lawrence-forooghian added a commit that referenced this issue Dec 2, 2024
@lawrence-forooghian
Implement CHA-PR3h and similar
cf769a1 
Resolves #151.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
room-lifecycle Related to room lifecycle (temporary label).
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ECO-5144] Implement CHA-PR3h etc ably/ably-chat-swift
2 participants
@lawrence-forooghian @jamienewcomb