Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/agent header #9

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Feature/agent header #9

merged 6 commits into from
Oct 31, 2022

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Oct 26, 2022 •
edited by sync-by-unito bot
Loading

  • Added agent header support with proper lib versioning.
  • Updated README for release process

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Oct 26, 2022

Added as a part of ably/ably-common#170

@sacOO7 sacOO7 marked this pull request as ready for review October 30, 2022 09:57
@sacOO7
Merge branch 'master' into feature/agent-header
82edeee 
# Conflicts:
#	.github/README.md
qsdstefan
qsdstefan approved these changes Oct 30, 2022
View reviewed changes
Copy link

@qsdstefan qsdstefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sacOO7 sacOO7 mentioned this pull request Oct 30, 2022
Closed
owenpearson
owenpearson approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Oct 31, 2022

Merging the PR since it's approved : )

@sacOO7 sacOO7 merged commit 753219a into master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

@qsdstefan qsdstefan qsdstefan approved these changes

@AmirQSD AmirQSD Awaiting requested review from AmirQSD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sacOO7 @qsdstefan @owenpearson