Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Application for Alzheimers Detection #561

Merged
merged 18 commits into from
May 16, 2024

Conversation

aindree-2005
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : Web Application for Alzheimers Detection #539

  • Info about the related issue (Aim of the project) : Web Application for Alzheimers Detection
  • Name: Aindree
  • GitHub ID: aindree2005
  • Email ID:
  • Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) GSSOC 2024

Closes: #539

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @aindree-2005 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Add the video in the README file of the Web App folder, just like reference project given in the issue template.

For that, firstly upload a thumbnail for the video, then use this markdown script by putting thumbnail and video URL. Here is the script, [![](thumbnail_url)](uploaded_video_url).

@aindree-2005

@abhisheks008 abhisheks008 added Status: Requested Changes Changes requested. gssoc Girlscript Summer of Code 2024 labels May 15, 2024
@aindree-2005
Copy link
Contributor Author

Looks good to me. Add the video in the README file of the Web App folder, just like reference project given in the issue template.

For that, firstly upload a thumbnail for the video, then use this markdown script by putting thumbnail and video URL. Here is the script, [![](thumbnail_url)](uploaded_video_url).

@aindree-2005

@abhisheks008 made the change. Is it ok now? Had uploaded the demo.mp4 already

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Your PR is approved and ready to be merged.

I'll merge the PR by EOD.

@aindree-2005

@abhisheks008 abhisheks008 added Status: Ready to Merge level 2 Level 2 for GSSOC level 3 Level 3 for GSSOC and removed Status: Requested Changes Changes requested. level 2 Level 2 for GSSOC labels May 16, 2024
@abhisheks008
Copy link
Owner

abhisheks008 commented May 16, 2024

Hi @aindree-2005 need a minor change. Can you represent the demo video like this,
image

For your reference you can have a look at this project, Brain Tumor Detection/Web App

@aindree-2005
Copy link
Contributor Author

Hi @aindree-2005 need a minor change. Can you represent the demo video like this, image

For your reference you can have a look at this project, Brain Tumor Detection/Web App

I used the same syntax as here, but the preview is looking different in mine. If I embed the video as before thumbnail is no longer appearing

@abhisheks008
Copy link
Owner

Have you tried this syntax [![](<put the whole URL of the thumbnail>)](<put the whole URL of the video>)

@aindree-2005
Copy link
Contributor Author

Have you tried this syntax [![](<put the whole URL of the thumbnail>)](<put the whole URL of the video>)

Yes tried that with the permalink

@abhisheks008
Copy link
Owner

abhisheks008 commented May 16, 2024

Have you tried this syntax [![](<put the whole URL of the thumbnail>)](<put the whole URL of the video>)

Yes tried that with the permalink

Still not getting the desired output?

Try this then, [![]()](<put the entire video URL>)

@abhisheks008
Copy link
Owner

Hi @theiturhs sorry to bother you here. Can you help @aindree-2005 for getting the desired way to represent the demo video in the README, just like you did it in your pull request. Aindree is not getting the desired output after several tries with the markdown.

@Sgvkamalakar
Copy link
Contributor

Hi @aindree-2005,

Drag and drop / Copy-paste the video from your PC to the GitHub readme where you wish to paste it as a thumbnail.

@theiturhs
Copy link
Contributor

@abhisheks008 Sure I can try

@aindree-2005 you can check this screenshot how I tried this

image

If nothing is working,

Open your web browser and go to the GitHub repository where you want to edit the README file. Open it for editing. Try to drag the video from your local folder to README area and drop it into the README editing area. When you drop the video, some text representing the file path or URL might appear in the README. Adjust the markdown to properly embed the video (adjust the brackets). This is the easiest way. I hope this method will help you.

@aindree-2005
Copy link
Contributor Author

@abhisheks008 Sure I can try

@aindree-2005 you can check this screenshot how I tried this

image

If nothing is working,

Open your web browser and go to the GitHub repository where you want to edit the README file. Open it for editing. Try to drag the video from your local folder to README area and drop it into the README editing area. When you drop the video, some text representing the file path or URL might appear in the README. Adjust the markdown to properly embed the video (adjust the brackets). This is the easiest way. I hope this method will help you.

Thanks a lot! Trying that method rn

@aindree-2005
Copy link
Contributor Author

@abhisheks008 Sure I can try

@aindree-2005 you can check this screenshot how I tried this

image

If nothing is working,

Open your web browser and go to the GitHub repository where you want to edit the README file. Open it for editing. Try to drag the video from your local folder to README area and drop it into the README editing area. When you drop the video, some text representing the file path or URL might appear in the README. Adjust the markdown to properly embed the video (adjust the brackets). This is the easiest way. I hope this method will help you.

None of these worked, as video is not running in the markdown, it is always redirecting to concerned site

@aindree-2005
Copy link
Contributor Author

Nvm fixed it. No idea why same glitch was showing for Github.dev but not on VS Code. @abhisheks008 is this fine now?

@abhisheks008
Copy link
Owner

Nvm fixed it. No idea why same glitch was showing for Github.dev but not on VS Code. @abhisheks008 is this fine now?

Let me check.

@abhisheks008
Copy link
Owner

Nopes @aindree-2005 it's not working like the way others did.

@aindree-2005
Copy link
Contributor Author

Nopes @aindree-2005 it's not working like the way others did.

No idea why. It's working on VS Code Readme preview. I searched on google and it states that video src is the way but it doesn't work on all browsers. What should I do?

@Sgvkamalakar
Copy link
Contributor

@abhisheks008 Sure I can try
@aindree-2005 you can check this screenshot how I tried this
image
If nothing is working,
Open your web browser and go to the GitHub repository where you want to edit the README file. Open it for editing. Try to drag the video from your local folder to README area and drop it into the README editing area. When you drop the video, some text representing the file path or URL might appear in the README. Adjust the markdown to properly embed the video (adjust the brackets). This is the easiest way. I hope this method will help you.

None of these worked, as video is not running in the markdown, it is always redirecting to concerned site

Hi @aindree-2005,

Drag and drop / Copy-paste the video from your PC to the GitHub readme where you wish to paste it as a thumbnail.

@aindree-2005
Copy link
Contributor Author

@abhisheks008 Sure I can try
@aindree-2005 you can check this screenshot how I tried this
image
If nothing is working,
Open your web browser and go to the GitHub repository where you want to edit the README file. Open it for editing. Try to drag the video from your local folder to README area and drop it into the README editing area. When you drop the video, some text representing the file path or URL might appear in the README. Adjust the markdown to properly embed the video (adjust the brackets). This is the easiest way. I hope this method will help you.

None of these worked, as video is not running in the markdown, it is always redirecting to concerned site

Hi @aindree-2005,

Drag and drop / Copy-paste the video from your PC to the GitHub readme where you wish to paste it as a thumbnail.

Does this redirect to the video in the markdown? Not working for me. It always opens video separately

@Sgvkamalakar
Copy link
Contributor

@abhisheks008 Sure I can try
@aindree-2005 you can check this screenshot how I tried this
image
If nothing is working,
Open your web browser and go to the GitHub repository where you want to edit the README file. Open it for editing. Try to drag the video from your local folder to README area and drop it into the README editing area. When you drop the video, some text representing the file path or URL might appear in the README. Adjust the markdown to properly embed the video (adjust the brackets). This is the easiest way. I hope this method will help you.

None of these worked, as video is not running in the markdown, it is always redirecting to concerned site

Hi @aindree-2005,
Drag and drop / Copy-paste the video from your PC to the GitHub readme where you wish to paste it as a thumbnail.

Does this redirect to the video in the markdown? Not working for me. It always opens video separately

The video will be played within the markdown file and it worked. Check out the video below

Demo.mp4

@aindree-2005
Copy link
Contributor Author

I tried this way. Is it working?

Video Demo📽️

alt text

Watch Video Demo

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nopes it's just hyperlinking the video file, this way it can't be played inside the README.

@abhisheks008 abhisheks008 merged commit 498195f into abhisheks008:main May 16, 2024
@abhisheks008
Copy link
Owner

Hi @aindree-2005 fixed that issue regarding the demo video. You need to drag and drop the recorded video from your system to GitHub README file directly. That's all you have to do. You can try this in your forked repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girlscript Summer of Code 2024 level 3 Level 3 for GSSOC Points Updated Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Addition]: Web Application for Alzheimers Detection
4 participants