Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Enhancement]: Colour Detection using DL #547

Conversation

Arihant-Bhandari
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : [Model Enhancement]: Colour Detection using DL

Closes: #529 [Model Enhancement]: Colour Detection using DL

Describe the add-ons or changes you've made 📃

i have enchanced the previous model by adding the new image loading function from keras.utils, Attention mechanism, using ELU instead of ReLU due to its better functionality, made the problem into a multi-class classification model with softmax implementation, used the optimizer Nadam with lr = 0.01, displayed the first 32 kernels based on the images, saved and included the best model as part of the PR.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

The model was tested on Accuracxy, Precision, F1-score, Recall and confusion matrtix:

Accuracy: 0.94

Precision: 0.9565476190476192

Recall: 0.9514285714285714

F1 Score: 0.95005439005439

Confusion Matrix:
[[6 0 0 0 1 0 0 0 0 0]
[0 4 0 0 0 0 0 0 0 0]
[0 0 7 0 0 0 0 0 0 0]
[0 0 0 2 0 0 0 0 0 0]
[0 0 0 0 6 0 0 0 0 0]
[0 0 0 0 0 4 0 0 0 1]
[0 0 1 0 0 0 6 0 0 0]
[0 0 0 0 0 0 0 5 0 0]
[0 0 0 0 0 0 0 0 2 0]
[0 0 0 0 0 0 0 0 0 5]]

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @Arihant-Bhandari :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Arihant-Bhandari your model looks good to me. As you are enhancing the existing project, add your cells inside the existing .ipynb file and document that properly inside the .ipynb file. Also update the existing README as per your model accuracy score.

@abhisheks008 abhisheks008 added Status: Requested Changes Changes requested. gssoc Girlscript Summer of Code 2024 labels May 13, 2024
@Arihant-Bhandari
Copy link
Contributor Author

hi @abhisheks008 i wanted to know if i should completely change the README file, since someone worked on it yesterday, and it is signed off with their name, should i keep mine in tandem or delete theirs and add mine, i wanted to know before finalizing on it.

@abhisheks008
Copy link
Owner

hi @abhisheks008 i wanted to know if i should completely change the README file, since someone worked on it yesterday, and it is signed off with their name, should i keep mine in tandem or delete theirs and add mine, i wanted to know before finalizing on it.

Put it like this,
README Enhanced by,
Model Enhanced by,

We should give credit to the contributor who enhanced and corrected the README earlier.

@Arihant-Bhandari Arihant-Bhandari force-pushed the enhance_colour_detect branch from fe28824 to 1f6cf1a Compare May 13, 2024 15:58
@abhisheks008 abhisheks008 added wontfix ❌ This will not be worked on and removed Status: Requested Changes Changes requested. gssoc Girlscript Summer of Code 2024 labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Model Enhancement]: Colour Detection using DL
2 participants