Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concrete Compressive Strength Prediction #381

Merged
merged 8 commits into from
Dec 11, 2023

Conversation

aindree-2005
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : Concrete Compressive Strength

  • Info about the related issue (Aim of the project) :
    Concrete Compressive Strength Prediction with Multiple Models
  • Name: Aindree
  • GitHub ID: aindree2005
  • Email ID: [email protected]
  • **Idenitfy yourself: Codepeak Participant

closes #380

Describe the add-ons or changes you've made 📃

Comparison between LGBMRegressor, and Neural Network
Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Tested on Kaggle

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @aindree-2005 :)

@abhisheks008 abhisheks008 changed the title Concrete dl Concrete Compressive Strength Prediction Dec 11, 2023
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aindree-2005 nicely represented. Few changes are required. Please update the README.md file as per the given template, https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md

@abhisheks008 abhisheks008 added the Status: Requested Changes Changes requested. label Dec 11, 2023
@aindree-2005
Copy link
Contributor Author

Hi @aindree-2005 nicely represented. Few changes are required. Please update the README.md file as per the given template, https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md

@abhisheks008 fixed it now! Changed Readme in Models folder to include this data

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Your PR is approved and ready to be merged.
@aindree-2005

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. Level: MEDIUM Codepeak23 This issue is assigned under CodePeak 2023 event/ and removed Status: Requested Changes Changes requested. labels Dec 11, 2023
@abhisheks008 abhisheks008 merged commit 7cdf866 into abhisheks008:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codepeak23 This issue is assigned under CodePeak 2023 event/ Level: MEDIUM Points Updated Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concrete Strength Detection Using DL
2 participants