Integration Tests Setup for MSSQL #57
Conversation
rahulreddy15
force-pushed
the
integration_tests
branch
from
ce7349e to
0097524
Compare
|
There is a know issue where Github Actions Runners cannot run older MSSQL versions. So tests for the oldest supported versions are commented out. |
rahulreddy15
force-pushed
the
integration_tests
branch
from
5de8252 to
d5e3edd
Compare
@rahulreddy15 |
Yeah. The ubuntu 16 base image that MSSQL Server 2017 is based on crashes in newer Ubuntu versions ex: 22, 24. |
| func waitForMSSQLIsUpAndRunning(maxTries int) bool { | ||
| mssqlEnvVars := []string{ | ||
| "ACCEPT_EULA=Y", | ||
| fmt.Sprintf("SA_PASSWORD=%s", dbPassword), | ||
| "MSSQL_PID=Developer", |
There was a problem hiding this comment.
Out of curiosity: the 'try to connect until the server is up' approach (instead of the new sleep 120 in the Makefile) doesn't work anymore? I'm asking because it might be faster if the server doesn't take that long to be up and running.
There was a problem hiding this comment.
We are doing more things than before:
-> Setup DB
-> Restore DB from backup
-> Enable QUERY STORE on restore DB so the new functionality can work.
Waiting for all this to be done seems more complicated. So defaulted to waiting 120 seconds so everything can be setup.
rahulreddy15
force-pushed
the
integration_tests
branch
from
95a7622 to
16ce4db
Compare
rahulreddy15
merged commit 71705dd
into
epic_db_query_performance_monitoring_fork
Integration tests for features added with Query Performance Monitoring.
Integrations tests cover these scenarios:
Perf Monitoring flag: enabled
The integration tests should run against the MSSQL Server 2017 & 2022
Verify if the stdout contains valid json's. Validate the stdout json's against defined json schemas
Perf Monitoring flag: enabled
The integration should be tested against a DB without the correct features / flags / extensions enabled
Perf Monitoring flag: disabled
The existing integration tests should run as expected without any errors