-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom envvar names #44
base: master
Are you sure you want to change the base?
Feature/custom envvar names #44
Conversation
731823c
to
6856d8d
Compare
Thank you for the PR, @operatorequals! Will review it shortly. |
6423475
to
7bb23c5
Compare
Just added support for With {
"key1":"value1",
"key2":"value2"
} - name: Read secrets from AWS Secrets Manager into environment variables
uses: operatorequals/aws-secrets-manager-action@feature/custom_envvar_names
with:
parse-json: true
secrets: |
json | CUSTOM_ENV_VAR_JSON
populates |
Hello @abhilash1in ! |
Is it possible for this to also support having no prefix as well? So in your example, if you had:
you'd get an environment with the values:
Apologies if this is already supported, I couldn't find any mention of it. Thanks! |
...actually, scratch my request -- I found a one-liner to do this for me; this is in Ruby but I expect it'd be similarly short in other languages:
where
|
Best you could do right now is:
and get keys like Also a syntax like:
must do exactly what you want! |
@operatorequals just so I understand, The syntax:
Would be able to import json secrets without a prefix? I believe that's what would happen form checking the code, but I'm not sure. I'd like to use this plug in, but need to be able to import json secrets with no prefix. |
Try it! It should work as I explained! |
@abhilash1in Is it good enough to merge back to master and bump a new version? |
This PR solves #42, enabling putting secrets under specific Environment Variable names. It does not work with Wildcard paths and throws an appropriate error about it.