Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change flattenJSONObject to return POSIX compliant names #26

Closed
wants to merge 7 commits into from
Closed

Change flattenJSONObject to return POSIX compliant names #26

wants to merge 7 commits into from

Conversation

cbui
Copy link
Contributor

@cbui cbui commented Jul 21, 2021

Closes #20

@cbui
Copy link
Contributor Author

cbui commented Jul 21, 2021

Should I remove the lock?

@abhilash1in
Copy link
Owner

abhilash1in commented Jul 21, 2021 •
edited
Loading

@cbui Thank you for your contribution!

Should I remove the lock?

Yes, please. I'll update package-lock.json in a separate commit after bumping up a few dependencies.

The PR looks good on the first glance. Will take another look once package-lock.json is removed and merge it in.

@cbui
Copy link
Contributor Author

cbui commented Jul 21, 2021

Removed.

@cbui Thank you for your contribution!

Thank you for this action 🥇

@abhilash1in abhilash1in force-pushed the master branch 3 times, most recently from 337e0a7 to 62a2140 Compare July 24, 2021 05:17
@emmanuelnk
Copy link

@cbui @abhilash1in Just FYI I don't think this PR is working
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhilash1in abhilash1in abhilash1in approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POSIX Warning on compliant secret
3 participants
@cbui @abhilash1in @emmanuelnk