[Tools] Use type fullname to avoid issue from class renaming. (Azure#…

…14147) * Optimize for CI filter. * Add support for TargetModule * Avoid the issue caused by renaming class. * Avoid the issue caused by renaming class. Co-authored-by: wyunchi-ms <[email protected]>
abhi7860 · Feb 7, 2021 · 069bfa5 · 069bfa5
1 parent aeb124d
commit 069bfa5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/tools/StaticAnalysis/IssueChecker/IssueChecker.cs b/tools/StaticAnalysis/IssueChecker/IssueChecker.cs
@@ -30,11 +30,11 @@ public class IssueChecker : IStaticAnalyzer
     {
         private readonly List<(string, string)> exceptionLogInfoList = new List<(string, string)>()
         {
-            ("BreakingChangeIssues.csv", "BreakingChangeIssues"),
-            ("AssemblyVersionConflict.csv", "AssemblyVersionConflict"),
-            ("SharedAssemblyConflict.csv", "SharedAssemblyConflict"),
-            ("MissingAssemblies.csv", "MissingAssembly"),
-            ("ExtraAssemblies.csv", "ExtraAssembly"),
+            ("BreakingChangeIssues.csv", typeof(BreakingChangeIssue).FullName),
+            ("AssemblyVersionConflict.csv", typeof(AssemblyVersionConflict).FullName),
+            ("SharedAssemblyConflict.csv", typeof(SharedAssemblyConflict).FullName),
+            ("MissingAssemblies.csv", typeof(MissingAssembly).FullName),
+            ("ExtraAssemblies.csv", typeof(ExtraAssembly).FullName),
         };
         public AnalysisLogger Logger { get; set; }
 

diff --git a/tools/StaticAnalysis/ReportRecordFactory.cs b/tools/StaticAnalysis/ReportRecordFactory.cs
@@ -28,23 +28,23 @@ public static class ReportRecordFactory
     {
         public static IReportRecord Create(string type)
         {
-            if (type.Equals("BreakingChangeIssue"))
+            if (type.Equals(typeof(BreakingChangeIssue).FullName))
             {
                 return new BreakingChangeIssue();
             }
-            if (type.Equals("AssemblyVersionConflict"))
+            if (type.Equals(typeof(AssemblyVersionConflict).FullName))
             {
                 return new AssemblyVersionConflict();
             }
-            if (type.Equals("SharedAssemblyConflict"))
+            if (type.Equals(typeof(SharedAssemblyConflict).FullName))
             {
                 return new SharedAssemblyConflict();
             }
-            if (type.Equals("MissingAssembly"))
+            if (type.Equals(typeof(MissingAssembly).FullName))
             {
                 return new MissingAssembly();
             }
-            if (type.Equals("ExtraAssembly"))
+            if (type.Equals(typeof(ExtraAssembly).FullName))
             {
                 return new ExtraAssembly();
             }