Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Basic Organization #1

Merged
merged 13 commits into from
Mar 8, 2021
Merged

Initialize Basic Organization #1

merged 13 commits into from
Mar 8, 2021

Conversation

gchhablani
Copy link
Collaborator

@gchhablani gchhablani commented Mar 6, 2021

Add initial code structure for running experiments. I will be adding a simple CNN model, with MNIST dataset and test it on Colab and then make it ready for review.

Once done, it should be merged by the reviewers using "Squash and merge" option. This will help in cleaner commits.

Also, even small changes should be made using PR, and after at least one of reviewers reviews them.

Currently, I am not writing the code for GridSearch as we have switched to OmegaConf configurations, I'll add that in a separate PR.

@gchhablani
Copy link
Collaborator Author

gchhablani commented Mar 8, 2021

Hi @abheesht17 @blackrosedragon2,

There is a bit of an issue with configs. While the latest omegaconf (2.1 dev), we can use the YAML Merge Syntax (See this PR, however, it is not compatible with Variable Interpolation (See this Issue). While, we can keep the configs to either have merges, or variable interpolation, but not both, we need to find better alternatives of configuration management to allow both. A clean way would be either

  1. to not use variable interpolation.
  2. to not use merge syntax.

Let me know which one is preferred, I'll change things accordingly.

@gchhablani
Copy link
Collaborator Author

Also, the code for the dataset class has some issues, which need to be addressed.

ReLU(),
MaxPool2d(kernel_size=2, stride=2),
)
self.linear_layers = Linear(4 * 7 * 7, 10)
self.linear_layers = Linear(32 * 3 * 3, 10)

def forward(self, x_in):
x_out = self.cnn_layers(x_in["image"])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add an element in the model config, huggingface_bool. If True, we can return the loss as well from the forward function.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The labels are there already.

@abheesht17 abheesht17 merged commit 1b1d155 into abheesht17:main Mar 8, 2021
@gchhablani gchhablani changed the title [WIP] Initialize Basic Organization Initialize Basic Organization Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants