Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add send message when validate failed #21

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Add send message when validate failed #21

merged 1 commit into from
Jan 5, 2022

Conversation

na-ga
Copy link
Member

@na-ga na-ga commented Jan 5, 2022

For example, if you have set the mergers parameter, you will not notice the failure because nothing happens on validation error.

@na-ga na-ga requested a review from 0daryo as a code owner January 5, 2022 06:33
0daryo
0daryo approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@0daryo 0daryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@na-ga na-ga merged commit 6564f52 into main Jan 5, 2022
@na-ga na-ga deleted the add-send-message-when-validate-failed branch January 5, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0daryo 0daryo 0daryo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@na-ga @0daryo