Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade gradle and agp #34

Merged
merged 12 commits into from
Nov 19, 2024
Merged

upgrade gradle and agp #34

merged 12 commits into from
Nov 19, 2024

Conversation

YukiMatsumura
Copy link
Contributor

@YukiMatsumura YukiMatsumura commented Nov 18, 2024

関連ツールのアップグレード

  • Gradle 7.6 → 8.9
  • AGP 7.4.2 → 8.7.2
  • lint 31.0.2 → 31.7.2

下記の問題に対応

FlagfitのサンプルアプリのLintがfailする。

val expiryDate = (annotationAttributes.firstOrNull { it.name == "expiryDate" }
?.evaluate() as String?) ?: ""

ここで flagfit 側の EXPIRY_DATE_NOT_DEFINEDEXPIRY_DATE_INFINITE の定数参照してると、evaluate() の結果が null になり Lint Errorになってしまう。

サンプルアプリ側で const val ... の再定義して参照させるとパスする。
一旦WorkAroundを入れて対応する。

これを受けて、GitHub ActionsにサンプルアプリのLintが通ることををテストに追加した。

Copy link
Contributor

@momomomo111 momomomo111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥸

@YukiMatsumura
Copy link
Contributor Author

@momomomo111

FlagfitのサンプルアプリのLintがfailする件、descriptionに追記しました。
原因はまだ分かってません。ワークアラウンドになっちゃいますが一旦入れておきます。

Copy link
Contributor

@momomomo111 momomomo111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇.
Looks good👍

@YukiMatsumura YukiMatsumura merged commit 2ab336d into main Nov 19, 2024
1 check passed
@YukiMatsumura YukiMatsumura deleted the yuki/gradle-agp-upgradle branch November 19, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants