Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept a single tag= selector in iterators #45

Merged
merged 1 commit into from
Apr 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions lxml-stubs/etree/_element.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -106,41 +106,50 @@ class _Element:
) -> Iterator[Self]: ...
@overload
def itersiblings(
self, *, tag: Iterable[_t._TagSelector] | None = None, preceding: bool = False
self,
*,
tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None,
preceding: bool = False,
) -> Iterator[Self]: ...
@overload
def iterancestors(self, *tags: _t._TagSelector) -> Iterator[Self]: ...
@overload
def iterancestors(
self, *, tag: Iterable[_t._TagSelector] | None = None
self, *, tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None
) -> Iterator[Self]: ...
@overload
def iterdescendants(self, *tags: _t._TagSelector) -> Iterator[Self]: ...
@overload
def iterdescendants(
self, *, tag: Iterable[_t._TagSelector] | None = None
self, *, tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None
) -> Iterator[Self]: ...
@overload
def iterchildren(
self, *tags: _t._TagSelector, reversed: bool = False
) -> Iterator[Self]: ...
@overload
def iterchildren(
self, *, tag: Iterable[_t._TagSelector] | None = None, reversed: bool = False
self,
*,
tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None,
reversed: bool = False,
) -> Iterator[Self]: ...
@overload
def iter(self, *tags: _t._TagSelector) -> Iterator[Self]: ...
@overload
def iter(
self, *, tag: Iterable[_t._TagSelector] | None = None
self, *, tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None
) -> Iterator[Self]: ...
@overload
def itertext(
self, *tags: _t._TagSelector, with_tail: bool = True
) -> Iterator[str]: ...
@overload
def itertext(
self, *, tag: Iterable[_t._TagSelector] | None = None, with_tail: bool = True
self,
*,
tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None,
with_tail: bool = True,
) -> Iterator[str]: ...
def makeelement(
self,
Expand Down
21 changes: 15 additions & 6 deletions lxml-stubs/html/_element.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -148,41 +148,50 @@ class HtmlElement(etree.ElementBase):
) -> Iterator[HtmlElement]: ...
@overload
def itersiblings(
self, *, tag: Iterable[_TagSelector] | None = None, preceding: bool = False
self,
*,
tag: _TagSelector | Iterable[_TagSelector] | None = None,
preceding: bool = False,
) -> Iterator[HtmlElement]: ...
@overload
def iterancestors(self, *tags: _TagSelector) -> Iterator[HtmlElement]: ...
@overload
def iterancestors(
self, *, tag: Iterable[_TagSelector] | None = None
self, *, tag: _TagSelector | Iterable[_TagSelector] | None = None
) -> Iterator[HtmlElement]: ...
@overload
def iterdescendants(self, *tags: _TagSelector) -> Iterator[HtmlElement]: ...
@overload
def iterdescendants(
self, *, tag: Iterable[_TagSelector] | None = None
self, *, tag: _TagSelector | Iterable[_TagSelector] | None = None
) -> Iterator[HtmlElement]: ...
@overload
def iterchildren(
self, *tags: _TagSelector, reversed: bool = False
) -> Iterator[HtmlElement]: ...
@overload
def iterchildren(
self, *, tag: Iterable[_TagSelector] | None = None, reversed: bool = False
self,
*,
tag: _TagSelector | Iterable[_TagSelector] | None = None,
reversed: bool = False,
) -> Iterator[HtmlElement]: ...
@overload
def iter(self, *tags: _TagSelector) -> Iterator[HtmlElement]: ...
@overload
def iter(
self, *, tag: Iterable[_TagSelector] | None = None
self, *, tag: _TagSelector | Iterable[_TagSelector] | None = None
) -> Iterator[HtmlElement]: ...
@overload
def itertext(
self, *tags: _TagSelector, with_tail: bool = True
) -> Iterator[str]: ...
@overload
def itertext(
self, *, tag: Iterable[_TagSelector] | None = None, with_tail: bool = True
self,
*,
tag: _TagSelector | Iterable[_TagSelector] | None = None,
with_tail: bool = True,
) -> Iterator[str]: ...
def makeelement(
self,
Expand Down