fix: Accept a single tag= selector in iterators

abelcheung · Apr 12, 2024 · 502e957 · 502e957
1 parent 0eeff79
commit 502e957
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 12 deletions.
diff --git a/lxml-stubs/etree/_element.pyi b/lxml-stubs/etree/_element.pyi
@@ -106,41 +106,50 @@ class _Element:
     ) -> Iterator[Self]: ...
     @overload
     def itersiblings(
-        self, *, tag: Iterable[_t._TagSelector] | None = None, preceding: bool = False
+        self,
+        *,
+        tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None,
+        preceding: bool = False,
     ) -> Iterator[Self]: ...
     @overload
     def iterancestors(self, *tags: _t._TagSelector) -> Iterator[Self]: ...
     @overload
     def iterancestors(
-        self, *, tag: Iterable[_t._TagSelector] | None = None
+        self, *, tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None
     ) -> Iterator[Self]: ...
     @overload
     def iterdescendants(self, *tags: _t._TagSelector) -> Iterator[Self]: ...
     @overload
     def iterdescendants(
-        self, *, tag: Iterable[_t._TagSelector] | None = None
+        self, *, tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None
     ) -> Iterator[Self]: ...
     @overload
     def iterchildren(
         self, *tags: _t._TagSelector, reversed: bool = False
     ) -> Iterator[Self]: ...
     @overload
     def iterchildren(
-        self, *, tag: Iterable[_t._TagSelector] | None = None, reversed: bool = False
+        self,
+        *,
+        tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None,
+        reversed: bool = False,
     ) -> Iterator[Self]: ...
     @overload
     def iter(self, *tags: _t._TagSelector) -> Iterator[Self]: ...
     @overload
     def iter(
-        self, *, tag: Iterable[_t._TagSelector] | None = None
+        self, *, tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None
     ) -> Iterator[Self]: ...
     @overload
     def itertext(
         self, *tags: _t._TagSelector, with_tail: bool = True
     ) -> Iterator[str]: ...
     @overload
     def itertext(
-        self, *, tag: Iterable[_t._TagSelector] | None = None, with_tail: bool = True
+        self,
+        *,
+        tag: _t._TagSelector | Iterable[_t._TagSelector] | None = None,
+        with_tail: bool = True,
     ) -> Iterator[str]: ...
     def makeelement(
         self,

diff --git a/lxml-stubs/html/_element.pyi b/lxml-stubs/html/_element.pyi
@@ -148,41 +148,50 @@ class HtmlElement(etree.ElementBase):
     ) -> Iterator[HtmlElement]: ...
     @overload
     def itersiblings(
-        self, *, tag: Iterable[_TagSelector] | None = None, preceding: bool = False
+        self,
+        *,
+        tag: _TagSelector | Iterable[_TagSelector] | None = None,
+        preceding: bool = False,
     ) -> Iterator[HtmlElement]: ...
     @overload
     def iterancestors(self, *tags: _TagSelector) -> Iterator[HtmlElement]: ...
     @overload
     def iterancestors(
-        self, *, tag: Iterable[_TagSelector] | None = None
+        self, *, tag: _TagSelector | Iterable[_TagSelector] | None = None
     ) -> Iterator[HtmlElement]: ...
     @overload
     def iterdescendants(self, *tags: _TagSelector) -> Iterator[HtmlElement]: ...
     @overload
     def iterdescendants(
-        self, *, tag: Iterable[_TagSelector] | None = None
+        self, *, tag: _TagSelector | Iterable[_TagSelector] | None = None
     ) -> Iterator[HtmlElement]: ...
     @overload
     def iterchildren(
         self, *tags: _TagSelector, reversed: bool = False
     ) -> Iterator[HtmlElement]: ...
     @overload
     def iterchildren(
-        self, *, tag: Iterable[_TagSelector] | None = None, reversed: bool = False
+        self,
+        *,
+        tag: _TagSelector | Iterable[_TagSelector] | None = None,
+        reversed: bool = False,
     ) -> Iterator[HtmlElement]: ...
     @overload
     def iter(self, *tags: _TagSelector) -> Iterator[HtmlElement]: ...
     @overload
     def iter(
-        self, *, tag: Iterable[_TagSelector] | None = None
+        self, *, tag: _TagSelector | Iterable[_TagSelector] | None = None
     ) -> Iterator[HtmlElement]: ...
     @overload
     def itertext(
         self, *tags: _TagSelector, with_tail: bool = True
     ) -> Iterator[str]: ...
     @overload
     def itertext(
-        self, *, tag: Iterable[_TagSelector] | None = None, with_tail: bool = True
+        self,
+        *,
+        tag: _TagSelector | Iterable[_TagSelector] | None = None,
+        with_tail: bool = True,
     ) -> Iterator[str]: ...
     def makeelement(
         self,