Skip to content

Commit

Permalink
Review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
abdonpijpelink committed Jan 25, 2024
1 parent 60587af commit 6acd051
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
6 changes: 5 additions & 1 deletion docs/reference/esql/functions/count-distinct.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ properties:
include::../../aggregations/metrics/cardinality-aggregation.asciidoc[tag=explanation]

The `COUNT_DISTINCT` function takes an optional second parameter to configure
the precision threshold.
the precision threshold. The precision_threshold options allows to trade memory
for accuracy, and defines a unique count below which counts are expected to be
close to accurate. Above this value, counts might become a bit more fuzzy. The
maximum supported value is 40000, thresholds above this number will have the
same effect as a threshold of 40000. The default value is `3000`.

*Supported types*

Expand Down
2 changes: 1 addition & 1 deletion docs/reference/esql/functions/left.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The number of characters to return.

*Description*

Returns the substring that extracts 'length' chars from the 'string' starting
Returns the substring that extracts 'length' chars from 'str' starting
from the left.

*Supported types*
Expand Down
7 changes: 3 additions & 4 deletions docs/reference/esql/functions/log10.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@ Numeric expression. If `null`, the function returns `null`.

*Description*

Returns the logarithm to base 10. The input can be any numeric value, the return value
is always a double.
Returns the logarithm to base 10. The input can be any numeric value, the return
value is always a double.

Logs of negative numbers are NaN. Logs of infinites are infinite, as is the log
of 0.
Logs of 0, negative numbers, and infinites return `null` as well as a warning.

*Supported types*

Expand Down
2 changes: 1 addition & 1 deletion docs/reference/esql/functions/right.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The number of characters to return.

*Description*

Return the substring that extracts 'length' chars from the 'string' starting
Return the substring that extracts 'length' chars from 'str' starting
from the right.

*Supported types*
Expand Down

0 comments on commit 6acd051

Please sign in to comment.