-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] initial recent activity page #76
base: master
Are you sure you want to change the base?
Conversation
this looks good to me for a start... can we have the commit timestamp and the author information (and a diff of the content) -- and not only the uri which was modified/added... deletion: well, using this strategy it is hard to detect, I thought that we might be able to fold over the commits and extract the information of removed/added/modified files from the commit... atom output should be pretty straightforward (but let's first make the html page and see what metadata we can get there)! |
fff4ed0
to
2aebf79
Compare
Latest push gets all changes to files (updates, deletes, creations) for every commit. I'll have to filter files that aren't articles (files with no article metadata) and limit the recent changes that would be displayed in the page. Then I'll move on to fixing how the context is displayed. |
I'm sorry, I'm currently lacking time to look into this very nice PR. Hopefully soon. |
No problem at all! I'm looking at longest common subsequence for diffing
the updated content.
https://www.ics.uci.edu/~eppstein/161/960229.html
http://algorithms.tutorialhorizon.com/dynamic-programming-longest-common-subsequence/
Seems simple enough. Will try implementing it later on my day so will let
you know how that goes.
…On Tue, Nov 22, 2016 at 9:36 PM, Hannes Mehnert ***@***.***> wrote:
I'm sorry, I'm currently lacking time to look into this very nice PR.
Hopefully soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#76 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABY-Qv-mjQPb-HwapxZhHPz_LQUcMoBhks5rAu_jgaJpZM4Ks1Da>
.
--
Gabe Jaldon
|
@hannesm I'm still keen on finishing up this PR. Latest push includes a diff algo that I ported from https://github.com/paulgb/simplediff/. It uses arrays and a lot of side-effects.
|
nice! :) yes, a custom module (maybe even a custom library, since this might be useful in other contexts, and as you mentioned there is no standalone small library providing such functionality (apart from patdiff which depends on core)). |
9fb8506
to
59bc57a
Compare
Could you rebase this on master (there are merge cinflicts) |
refs: #72