[Draft] Implementing a new branding service #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a rough draft that creates a new branding service to handle all custom branding related logic to reduce duplication. I have verified it works for all logo occurrences including default mode and dark mode. It does not include any tests yet.
Here is one potential implementation:
Issues Resolved
One possible implementation: Service that components can hook into that assists with the logic
Part of the design spike: opensearch-project#2045
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr