Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed Filters overwrite the Available Filters #63

Closed
Lakshan-Madushanka opened this issue May 15, 2024 · 1 comment · Fixed by #64
Closed

Renamed Filters overwrite the Available Filters #63

Lakshan-Madushanka opened this issue May 15, 2024 · 1 comment · Fixed by #64
Assignees
@Lakshan-Madushanka
Labels
bug Something isn't working

Comments

@Lakshan-Madushanka
Copy link
Collaborator

Here, we should not give priority to $renamedFilters if $availableFilters are defined.
@Lakshan-Madushanka Lakshan-Madushanka mentioned this issue May 15, 2024
Open
@Lakshan-Madushanka Lakshan-Madushanka added the bug Something isn't working label May 15, 2024
@Lakshan-Madushanka Lakshan-Madushanka self-assigned this May 17, 2024
Lakshan-Madushanka added a commit that referenced this issue May 17, 2024
@Lakshan-Madushanka
Fix #63.Renamed Filters overwrite available Filters issue
a7d1167
@Lakshan-Madushanka Lakshan-Madushanka mentioned this issue May 17, 2024
Merged
@abbasudo
Copy link
Owner

Hi @Lakshan-Madushanka Thanks for reviewing #60 and finding this bug.

abbasudo added a commit that referenced this issue May 17, 2024
@abbasudo
Merge pull request #64 from abbasudo/bug-fix
13cf23b 
Fix #63. Renamed Filters overwrite available Filters issue
@olivierbaudouin olivierbaudouin mentioned this issue Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lakshan-Madushanka Lakshan-Madushanka

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #63. Renamed Filters overwrite available Filters issue abbasudo/laravel-purity
2 participants
@Lakshan-Madushanka @abbasudo