How to apply multiple filters to same exists sub query?

[IndexZer0]

See example below.

Am I crafting the filters in the correct format here?

$filters = [
    'name' => [
        '$in' => [
            'Name'
        ],
    ],
    'books' => [
        'name' => [
            '$in' => [
                'Game'
            ],
        ],
        'description' => [
            '$in' => [
                'Thrones',
            ],
        ],  
    ],
],

$results = Author::filter($filters)->get();

Abbasudo\Purity\Exceptions\FieldNotSupported: The field 'books' is not supported for model App\Models\Book.

[IndexZer0]

@abbasudo - Would be great for your input here. There is no example in the documentation on filtering by multiple relationship properties.

When I try the above, it fails when trying to apply the second filter inside the books array.

name gets applied to the books exists sub query
but description fails.

Am I using this package wrong or is this a limitation?

[IndexZer0]

I did just fork the repo and run the test and is working for me inside the package.

Throwing FieldNotSupported exception when using package inside a laravel app.

Odd one.

[IndexZer0]

@num8er - Any thoughts on what I mentioned about the way the query is constructed with two exists sub queries?

[num8er]

@num8er - Any thoughts on what I mentioned about the way the query is constructed with two exists sub queries?

Cause there is no $or filter, so it made 2 different queries.

[num8er]

I did just fork the repo and run the test and is working for me inside the package.

Throwing FieldNotSupported exception when using package inside a laravel app.

Odd one.

Make sure Your models and etc not cached, maybe worth to try clean artisan caches.

[IndexZer0]

Not trying to do an or query. Doesn't it make sense that both the name and description clauses should happen within the same exists sub query?

Why do exists twice?

[IndexZer0]

@IndexZer0 change input to this and send me the results

$filters = [
    'name' => [
        '$in' => [
            'Name'
        ],
    ],
    'books' => [
        'name' => [
            '$in' => [
                'Game'
            ],
        ],
    ],
    'books' => [
        'description' => [
            '$in' => [
                'Thrones',
            ],
        ],
    ],
];

You've got books as an array key twice so invalid array. Anyway, here is what happens.

"select * from `authors` where `name` in (?) and exists (select * from `books` where `authors`.`id` = `books`.`author_id` and `description` in (?))"

array:2 [
  0 => "Name"
  1 => "Thrones"
]

[num8er]

@IndexZer0 You're using same key books twice in assoc array. So it's not possible and last one will replace it.

Your initial array is correct:

$filters = [
    'name' => [
        '$in' => [
            'Name'
        ],
    ],
    'books' => [
        'name' => [
            '$in' => [
                'Game'
            ],
        ],
        'description' => [
            '$in' => [
                'Thrones',
            ],
        ],  
    ],
],

[IndexZer0]

Lol yes I know. @abbasudo told me to to run that example and I pointed that out. 🙂

[num8er]

@IndexZer0 @abbasudo I made another test where I'm requesting using http and passing filters via query string.
So both of them generate same sql queries:

[IndexZer0]

@abbasudo

Okay, had a screenshare with @num8er

We found that the bug does not exist in dev-master when i composer require in my application.

v3.2.0 is broken.

v3.2.0 was released containing bug. PR #49 fixed issue. no release done since.

Can a release be done from current master please.

[num8er]

@abbasudo I propose tests to written in non silent mode.
Cause since silent mode hides most of issues like with @IndexZer0 we are having unexpected, invisible bugs.

[IndexZer0]

@num8er Thanks for working with me to find cause of issue.

[num8er]

@IndexZer0 welcome :)

[abbasudo]

@IndexZer0 that's great to know. thanks for informing me. just drafted a new release.

[abbasudo]

@abbasudo I propose tests to written in non silent mode. Cause since silent mode hides most of issues like with @IndexZer0 we are having unexpected, invisible bugs.

@num8er Good idea. thanks for your help.