fix some tests

abbasudo · Jun 4, 2024 · 443952c · 443952c
1 parent 180b167
commit 443952c
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/src/Filters/Strategies/ContainsCaseSensitiveFilter.php b/src/Filters/Strategies/ContainsCaseSensitiveFilter.php
@@ -35,7 +35,7 @@ public function apply(): Closure
                         $query->whereRaw("`{$this->column}` COLLATE BINARY like ?", ["%{$value}%"]);
                         break;
                     case 'pgsql':
-                        $query->whereRaw("`{$this->column}`::bytea LIKE ?", ["%{$value}%"]);
+                        $query->where($this->column, 'LIKE', "%{$value}%");
                         break;
                     case 'sqlsrv':
                         $query->whereRaw("`{$this->column}` COLLATE Latin1_General_BIN LIKE ?", ["%{$value}%"]);

diff --git a/src/Filters/Strategies/EndsWithCaseSensitiveFilter.php b/src/Filters/Strategies/EndsWithCaseSensitiveFilter.php
@@ -29,16 +29,16 @@ public function apply(): Closure
             foreach ($this->values as $value) {
                 switch ($connection) {
                     case 'mysql':
-                        $query->whereRaw("BINARY `{$this->column}` like ?", '%'.$value);
+                        $query->whereRaw("BINARY `{$this->column}` like ?", '%' . $value);
                         break;
                     case 'sqlite':
-                        $query->whereRaw("`{$this->column}` COLLATE BINARY like ?", '%'.$value);
+                        $query->whereRaw("`{$this->column}` COLLATE BINARY like ?", '%' . $value);
                         break;
                     case 'pgsql':
-                        $query->whereRaw("`{$this->column}` LIKE ?", '%'.$value);
+                        $query->where($this->column, 'LIKE', '%' . $value);
                         break;
                     case 'sqlsrv':
-                        $query->whereRaw("`{$this->column}` COLLATE Latin1_General_BIN LIKE ?", '%'.$value);
+                        $query->whereRaw("`{$this->column}` COLLATE Latin1_General_BIN LIKE ?", '%' . $value);
                         break;
                     default:
                         throw new RuntimeException("Unsupported database driver: {$connection}");

diff --git a/src/Filters/Strategies/NotContainsSensitiveFilter.php b/src/Filters/Strategies/NotContainsSensitiveFilter.php
@@ -35,7 +35,7 @@ public function apply(): Closure
                         $query->whereRaw("`{$this->column}` COLLATE BINARY not like ?", ["%{$value}%"]);
                         break;
                     case 'pgsql':
-                        $query->whereRaw("`{$this->column}` not LIKE ?", ["%{$value}%"]);
+                        $query->whereNot($this->column, 'LIKE', "%{$value}%");
                         break;
                     case 'sqlsrv':
                         $query->whereRaw("`{$this->column}` COLLATE Latin1_General_BIN not LIKE ?", ["%{$value}%"]);

diff --git a/src/Filters/Strategies/StartsWithCaseSensitiveFilter.php b/src/Filters/Strategies/StartsWithCaseSensitiveFilter.php
@@ -29,16 +29,16 @@ public function apply(): Closure
             foreach ($this->values as $value) {
                 switch ($connection) {
                     case 'mysql':
-                        $query->whereRaw("BINARY `{$this->column}` like ?", $value.'%');
+                        $query->whereRaw("BINARY `{$this->column}` like ?", $value . '%');
                         break;
                     case 'sqlite':
-                        $query->whereRaw("`{$this->column}` COLLATE BINARY like ?", $value.'%');
+                        $query->whereRaw("`{$this->column}` COLLATE BINARY like ?", $value . '%');
                         break;
                     case 'pgsql':
-                        $query->whereRaw("`{$this->column}` LIKE ?", $value.'%');
+                        $query->where($this->column, 'LIKE', $value . '%');
                         break;
                     case 'sqlsrv':
-                        $query->whereRaw("`{$this->column}` COLLATE Latin1_General_BIN LIKE ?", $value.'%');
+                        $query->whereRaw("`{$this->column}` COLLATE Latin1_General_BIN LIKE ?", $value . '%');
                         break;
                     default:
                         throw new RuntimeException("Unsupported database driver: {$connection}");

diff --git a/tests/Feature/FilterableTest.php b/tests/Feature/FilterableTest.php
@@ -271,7 +271,7 @@ public function it_can_filter_with_notIn_operator(): void
     /** @test */
     public function it_can_filter_with_contains_operator(): void
     {
-        $response = $this->getJson('/posts?filters[title][$contains]=LARAVEL');
+        $response = $this->getJson('/posts?filters[title][$contains]=laravel');
 
         $response->assertOk();
         $response->assertJsonCount(1);
@@ -289,7 +289,7 @@ public function it_can_filter_with_notContains_operator(): void
     /** @test */
     public function it_can_filter_with_containsc_operator(): void
     {
-        $response = $this->getJson('/posts?filters[title][$containsc]=lara');
+        $response = $this->getJson('/posts?filters[title][$containsc]=laravel');
         $response->assertOk();
         $response->assertJsonCount(1);
     }